Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify eglot behavior #7

Merged
merged 4 commits into from
Oct 22, 2019
Merged

Clarify eglot behavior #7

merged 4 commits into from
Oct 22, 2019

Conversation

non-Jedi
Copy link
Contributor

Eglot treats the offset as characters by default (codepoints).
joaotavora/eglot#125

Eglot and lsp-mode no longer listed as "work in progress" on https://langserver.org

non-Jedi and others added 3 commits October 18, 2019 09:42
Eglot treats the offset as characters by default (codepoints).
joaotavora/eglot#125

Eglot and lsp-mode no longer listed as "work in progress" on https://langserver.org
It uses `(current-column)` for line position which is only related to
how emacs visually displays the file. Most of the time this is
equivalent to the unit being grapheme clusters though there will of
course be exceptions based on emacs font rendering.
@Avi-D-coder
Copy link
Owner

Where exactly does it say eglot uses codepoints?

@non-Jedi
Copy link
Contributor Author

In the issue they use the word "character" rather than codepoint. When looking at the code, eglot uses (- (point) (point-at-bol)) by default. The documentation around "point" just uses the word "character" again. But elsewhere in the manual, they say that each character corresponds to a unicode codepoint.

@non-Jedi
Copy link
Contributor Author

By the way, I couldn't make the "client counts" add up the way you showed. You may want to recount.

@Avi-D-coder
Copy link
Owner

Avi-D-coder commented Oct 18, 2019

By the way, I couldn't make the "client counts" add up the way you showed. You may want to recount.

That would be great thanks.

Keep in mind "Multiple implementations in the same repo or derived from a shared dependency are counted once." While technically all the JS/TS implementation use the same Microsoft libraries, Non Microsoft JS implementations can be counted individually.

Did not count https://github.com/TypeFox/monaco-languageclient since
it depends on a vscode npm module
@Avi-D-coder Avi-D-coder merged commit 60160ac into Avi-D-coder:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants