Skip to content

Conversation

@mbpowers
Copy link
Contributor

Added IPC functions for autHide, manualHide and toggleAutoHide, as well as general settings getter get arg and setter set arg value.

@bbedward
Copy link
Collaborator

I don't want to merge this one yet, because the multi bar branch is nearly ready to be merged and I opted to not keep backwards compatibility with bar related IPCs (in that world, auto hide becomes a per-bar setting not a global one) so the IPCs change like bar toggle 1-4 (because optional arguments aren't possible via IpcHandler afaik) so the bar related one at least, should follow the sam paradigm basically.

@mbpowers
Copy link
Contributor Author

Ah, makes sense. I can update this for multi-bar when that arrives unless the IPC is included, in which case I can separate out just the general settings getter and setter.

I think you are right about the optional arguments, I came across that as well.

@bbedward
Copy link
Collaborator

Multi bar has been merged to master

@mbpowers
Copy link
Contributor Author

Updated 👍 Also I changed reveal to show as we kinda had mixed language

}

IpcHandler {
function show(): string {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

show doesnt work in quickshell IPC context, its a reserved word I guess and it just makes it show the available functions. That's why they were reveal instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants