Add SwiftLog LogHandler conformance to DiagnosticsLogger (#150) - #212
Open
elio-Wang wants to merge 1 commit into
Open
Add SwiftLog LogHandler conformance to DiagnosticsLogger (#150)#212elio-Wang wants to merge 1 commit into
elio-Wang wants to merge 1 commit into
Conversation
Allow DiagnosticsLogger to be used as a backing store for SwiftLog's LoggingSystem by providing a DiagnosticsLogger.SwiftLogHandler type. Projects already using SwiftLog can now seamlessly forward all log messages into the Diagnostics report. - Add swift-log as a package dependency - Make DiagnosticsLogger.init() and .standard public - Add setup(_:) overload accepting a custom logger instance - Add DiagnosticsLogger.SwiftLogHandler nested LogHandler type - Map SwiftLog levels to Diagnostics debug/error CSS classes - Add unit tests for the SwiftLog integration Resolves AvdLee#150
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
DiagnosticsLogger.SwiftLogHandler, aLogHandlerconformance for apple/swift-log, so projects already using SwiftLog can bridge their logs into the Diagnostics report with a single bootstrap call:Resolves #150.
Changes
Notes
@unchecked Sendablematches swift-log's ownStreamLogHandlerpattern —metadata/logLevelare set at bootstrap, not mutated across threads.debuglevels, so the mapping groups the lower SwiftLog levels intodebug. Can be revisited if more levels are added later.