Update TextMateSharp and syntax highlight using ReadOnlyMemory<char> for reduced allocations#550
Update TextMateSharp and syntax highlight using ReadOnlyMemory<char> for reduced allocations#550
Conversation
| <IncludeSymbols>true</IncludeSymbols> | ||
| <EmbedUntrackedSources>true</EmbedUntrackedSources> | ||
|
|
||
| <Version>11.3.0</Version> |
There was a problem hiding this comment.
Minimal required version
There was a problem hiding this comment.
Minimal required version
@Gillibald
Isn't that property the main version number for AvaloniaEdit? Don't you bump the version number when you release a new version? Or is this not the version number for the AvaloniaEdit nuget package?
There was a problem hiding this comment.
This is not a release branch, so the version should not be adjusted. If a release is prepared, this needs to be adjusted.
There was a problem hiding this comment.
Ok thanks. Will a release be coming? I'm still waiting to get a fix for a bug that was fixed back in May. Much appreciated!
There was a problem hiding this comment.
@Gillibald @danipen will there be a release created soon?
There was a problem hiding this comment.
@udlose there are nightly builds for AvaloniaEdit, but not automatic. You can use 11.3.999-cibuild0059117-beta, but it doesn't include this PR
There was a problem hiding this comment.
This PR upgrades TextMateSharp from
v1.0.xtov2.0.2and addsReadOnlyMemory<char>APIs to reduce string allocations during syntax highlighting.Benchmark Results
See danipen/TextMateSharp#100
Tested with a 133,439 line C# file (5.8 MB):