Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Avalonia.ReactiveUI.Events #5423

Merged
merged 3 commits into from
May 1, 2021
Merged

Remove Avalonia.ReactiveUI.Events #5423

merged 3 commits into from
May 1, 2021

Conversation

rstm-sf
Copy link
Contributor

@rstm-sf rstm-sf commented Feb 3, 2021

What does the pull request do?

Remove Avalonia.ReactiveUI.Events

What is the current behavior?

Build problems with Pharmacist when upgrading sdk to net5

What is the updated/expected behavior with this PR?

Remove Avalonia.ReactiveUI.Events

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Avalonia.ReactiveUI.Events will no longer supports. Use Pharmacist.MSBuild instead. How to use it? https://github.com/reactiveui/Pharmacist#msbuild

cc: @worldbeater Can a better description be made for the end of support?

Fixed issues

@rstm-sf rstm-sf mentioned this pull request Feb 3, 2021
3 tasks
@worldbeater
Copy link
Contributor

Avalonia.ReactiveUI.Events is just a package that contains precompiled .Events(), so folks don't have to generate the wrappers on their own. Migrating from Avalonia.ReactiveUI.Events to Pharmacist.MsBuild should be quite simple, e.g. instead of referencing Avalonia.ReactiveUI.Events folks should reference Pharmacist.MsBuild as such:
image
And then rebuild the project:

dotnet build

After doing that, the events will generate automatically for Avalonia assemblies.
See also: https://github.com/reactiveui/pharmacist#nuget-packages

Copy link
Contributor

@worldbeater worldbeater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming ICSharpCode.Decompiler seems to be broken on Linux machines with .NET 5 installed, and this issue is blocking Avalonia .NET 5 upgrade, probably worth removing Avalonia.ReactiveUI.Events and recommending the direct consumption of Pharmacist.MsBuild as stated above.

Also assuming the Avalonia.ReactiveUI.Events package is already shipped to NuGet, the removal of this package from the main repository shouldn't even be much of an issue. The generated package is backward-compatible and is probably moving to its own repository in the future.

@maxkatz6 maxkatz6 enabled auto-merge April 22, 2021 15:11
@maxkatz6 maxkatz6 merged commit fa20271 into AvaloniaUI:master May 1, 2021
@rstm-sf rstm-sf deleted the infra/remove_ReactiveUI_Events branch May 1, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants