Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DateTimePickerPanelType enum backward compatibility #17398

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

rabbitism
Copy link
Contributor

@rabbitism rabbitism commented Nov 1, 2024

What does the pull request do?

The value (int) change of DateTimePickerPanelType.TimePeriod breaks backward compatibility. This PR brings it back.

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Well it breaks the breaking change.

Obsoletions / Deprecations

Fixed issues

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.3.999-cibuild0052939-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@rabbitism
Copy link
Contributor Author

@MrJul please help to review~

@maxkatz6 maxkatz6 added regression backport-candidate-11.2.x Consider this PR for backporting to 11.2 branch labels Nov 1, 2024
@MrJul MrJul added the bug label Nov 1, 2024
@MrJul
Copy link
Member

MrJul commented Nov 1, 2024

For context: added in #16079
Didn't get caught by the API validation diff.

@maxkatz6 maxkatz6 merged commit 680a5e2 into AvaloniaUI:master Nov 1, 2024
9 of 11 checks passed
maxkatz6 pushed a commit that referenced this pull request Nov 14, 2024
@maxkatz6 maxkatz6 added backported-11.2.x and removed backport-candidate-11.2.x Consider this PR for backporting to 11.2 branch labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants