Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed nearest font matching not working #16796

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

adirh3
Copy link
Contributor

@adirh3 adirh3 commented Aug 24, 2024

What does the pull request do?

Fixes issue that sometimes font match won't fallback to nearest font when needed, causing it to use the default font

What is the current behavior?

Many fonts are not showing properly on startup (mainly Chinese fonts)

What is the updated/expected behavior with this PR?

All fonts showing properly

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0051463-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@cla-avalonia
Copy link
Collaborator

cla-avalonia commented Aug 24, 2024

  • All contributors have signed the CLA.

@adirh3
Copy link
Contributor Author

adirh3 commented Aug 24, 2024

@cla-avalonia agree

@Gillibald
Copy link
Contributor

We need to add a unit test for this

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0051690-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6
Copy link
Member

@Gillibald can it be merged? Or do you wait for a unit test?

@Gillibald Gillibald added this pull request to the merge queue Sep 12, 2024
@Gillibald Gillibald added the backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch label Sep 12, 2024
Merged via the queue into AvaloniaUI:master with commit eb35631 Sep 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-textprocessing backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants