Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix android uri activation #16477

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Fix android uri activation #16477

merged 3 commits into from
Jul 26, 2024

Conversation

maxkatz6
Copy link
Member

What does the pull request do?

  1. Fixes android OpenUri/File activation by overriding correct OnCreate method.
  2. Makes AndroidActivatableLifetime redirect secondary activity activation into main activity.
  3. Makes SetContentView() call delayed. This way if derived activity doesn't set any Content (directly or view SingleViewLifetime), no SetContentView is called. Which helps for no-UI activities like DataScheme handlers.

Fixed issues

Fixes #16474
Fixes #16457

@maxkatz6 maxkatz6 requested a review from emmauss July 26, 2024 04:03
@maxkatz6 maxkatz6 added bug os-android backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Jul 26, 2024
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0050474-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@kekekeks kekekeks added this pull request to the merge queue Jul 26, 2024
Merged via the queue into master with commit 413ff78 Jul 26, 2024
12 checks passed
@kekekeks kekekeks deleted the fix-android-uri-activation branch July 26, 2024 05:55
maxkatz6 added a commit that referenced this pull request Aug 12, 2024
* Make SetContentView call delayed

* Make it possible to run secondary activity for OpenUri activation

* Add activation DataSchemeActivity example
@maxkatz6 maxkatz6 added backported-11.1.x and removed backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ActivatableLifetime for Android is not working ActivatableLifetime for Android is not working
3 participants