Only update selection on focus in TabControl if focus comes from TabItem. #16338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a temporary workaround to help Actipro's issues #15433: they're embedding other controls in a `TabControl`-derived control and they don't want these other controls to change the selection when they're focused.
|
You can test this PR using the following package version. |
maxkatz6
added
bug
backport-candidate-11.1.x
maxkatz6
approved these changes
Jul 17, 2024
|
Thanks, the update looks good on our end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This is a temporary workaround to help Actipro's issue #15433: they're embedding other controls in a
TabControl-derived control and they don't want these other controls to change the selection when they're focused.Ideally as that issue says, we'd be moving all interactions out of
TabControland intoTabItembut given that this would be a big behavioural breaking change to anyone deriving fromTabControl, we need to take smaller steps. This fix, along with them overridingTabControl.OnPointerPressedandTabControl.OnPointerReleasedshould allow them to work around the issue.