Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[X11] Ensure XSync before calling CreateNativeControlCore #15952

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

kekekeks
Copy link
Member

@kekekeks kekekeks commented Jun 7, 2024

We are currently calling CreateNativeControlCore when proposed parent XID is technically not yet visible to other clients, which leads to a race condition.

@kekekeks kekekeks added bug area-x11 backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Jun 7, 2024
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0048893-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added this pull request to the merge queue Jun 8, 2024
Merged via the queue into master with commit 4153ef7 Jun 8, 2024
12 checks passed
@maxkatz6 maxkatz6 deleted the fixes/x11-call-xsync-before-asking branch June 8, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-x11 backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants