ToolTip should use Popup internally + fix Popups not closing when placement target is closed #15358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
commented
Apr 14, 2024
maxkatz6
changed the title
|
You can test this PR using the following package version. |
grokys
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Simplifies bunch of code and should have been done a while ago. All other popup-like controls are already based on Popup itself - Flyout, ContextMenu. The same is expected about third party controls, none should use IPopupHost directly.
How was the solution implemented (if it's not obvious)?
There should be zero behavioral changes.
cc @grokys @TomEdwardsEnscape