ShowInTaskBar with Owned window: make consistent with WPF #12593
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repro
Current behavior (windows only)
When the loaded event happens, it will just remove the owner window. Meaning that the dialog will go behind the main window.
I checked WPFs behavior and it definately ignores ShowInTaskBar changes in this scenario.
ShowInTaskBar = false, causes SetParent to be called and parent set to HiddenWindow.Handle, and
_hiddenWindowIsParent = true;
Show gets called, SetParent sets the new owner. all good.
ShowInTaskbar gets set to true, but because
_hiddenWindowIsParent
was left true, it overwrites the owner window.casuing the issue.
Fixed behavior:
ensure _hiddenWindowIsParent is always in sync.
ShowInTaskbar is ignored and relationship maintained.