Improved Ripple visual effect#459
Merged
appleneko2001 merged 3 commits intoMay 18, 2025
Merged
Conversation
This was referenced Aug 1, 2025
This was referenced Jan 1, 2026
This was referenced Feb 1, 2026
This was referenced Mar 29, 2026
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR will correct some
RippleHandlerrenderer abnormal behaviours, which may happens some graphical issues while effects is working, also addingFadeOutDurationproperty to allow users to control how long it take to fade out.Exposed API
RippleEffect.FadeOutDurationduration for second state (fade-out)Changes
RippleHandler, thanks again to @maxkatz6 for converting this effect to custom renderer handler way.Known issues:
RippleEffect.FadeOutDurationshould not higher thanRipple.Duration, otherwise Ripple effect will be deleted early.Screenshots