Skip to content

Conversation

@LopeKinz
Copy link

!!!NEVER MERGE INTO MAIN BRANCH!!!

Refactored by Sourcery AI and Revieved by me.
Everything seems okay.
If Merged then send any issues to LOPEKINZ/taipy or pinkyhax@gmail.com

Stats:
2 Commits
153 Files Changed
1,195 Additions
1,123 Deletions

Most Common changes:
Replaced i with _ for Counting
Replaced "String" + "String with f"String {string}"
Changed Formats for better readability.

Sourcery AI and others added 2 commits December 13, 2023 08:29
@florian-vuillemot
Copy link
Member

@jrobinAV @FabienLelaquais
This PR is far from up to date. What can we do about it?

@FredLL-Avaiga
Copy link
Member

@jrobinAV @FabienLelaquais This PR is far from up to date. What can we do about it?

close it

@FabienLelaquais
Copy link
Member

I'm not sure I agree.
There are very relevant details that are pointed out, worth looking at.

It is definitively true that not all "anomalies" should be integrated (since many, for example, would badly impact the documentation). But I would certainly spend a day looking at this and integrating those that make sense, and are still relevant with the current state of the source code.
@jrobinAV and I will take care of a decision on this.

@jrobinAV
Copy link
Member

I agree with @FabienLelaquais.
For information, I believe many changes have been already incorporated.

@trgiangdo
Copy link
Contributor

I would certainly spend a day looking at this and integrating those that make sense, and are still relevant with the current state of the source code.

@FabienLelaquais I can take care of this if you may

@trgiangdo trgiangdo self-requested a review March 18, 2024 02:44
@jrobinAV jrobinAV added the 🖧 Devops Operations, monitoring, maintenance, deployment, packaging label Mar 19, 2024
@trgiangdo
Copy link
Contributor

Finished in #1007

@trgiangdo trgiangdo closed this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🖧 Devops Operations, monitoring, maintenance, deployment, packaging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants