Fix bytes#90
Merged
GaryJones merged 19 commits intoAutomattic:developfrom Aug 8, 2024
szepeviktor:fix-bytes
Merged
Conversation
GaryJones
requested changes
Aug 8, 2024
Contributor
GaryJones
left a comment
There was a problem hiding this comment.
I'm not usually a fan of so many changes in one PR, but I appreciate the efforts on this. If the JSON indentation issues can be fixed up, this can be merged.
Thanks Viktor!
Contributor
|
I appreciate the quick action! Can you change the |
Contributor
Author
|
All done. |
GaryJones
reviewed
Aug 8, 2024
GaryJones
approved these changes
Aug 8, 2024
Contributor
Author
|
Glad to contribute. |
Contributor
|
Wonderful - thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is all my knowledge on bytes. I call it byte-level care.
The Integrity workflow checks all these.
Review without white space changes: https://github.com/Automattic/zoninator/pull/90/files?diff=unified&w=1