Skip to content

Fix bytes#90

Merged
GaryJones merged 19 commits intoAutomattic:developfrom
szepeviktor:fix-bytes
Aug 8, 2024
Merged

Fix bytes#90
GaryJones merged 19 commits intoAutomattic:developfrom
szepeviktor:fix-bytes

Conversation

@szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Oct 20, 2023

Here is all my knowledge on bytes. I call it byte-level care.
The Integrity workflow checks all these.

  1. Remove stray spaces
  2. Deduplicate blank lines
  3. Obey EditorConfig including tabs vs. spaces and line end characters
  4. Don't export development files
  5. Add LICENSE file

Review without white space changes: https://github.com/Automattic/zoninator/pull/90/files?diff=unified&w=1

Copy link
Contributor

@GaryJones GaryJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not usually a fan of so many changes in one PR, but I appreciate the efforts on this. If the JSON indentation issues can be fixed up, this can be merged.

Thanks Viktor!

@GaryJones GaryJones added this to the 0.10.0 milestone Aug 8, 2024
@GaryJones GaryJones added type: maintenance Routine maintenance and code quality improvements status: awaiting feedback Awaiting feedback from reporter labels Aug 8, 2024
@GaryJones GaryJones changed the base branch from main to develop August 8, 2024 19:55
@GaryJones
Copy link
Contributor

I appreciate the quick action!

Can you change the composer.json back to using tab indentation please? Then I'll go ahead and merge this before I touch anything else.

@szepeviktor
Copy link
Contributor Author

All done.
Please do squash my commits.

@GaryJones GaryJones merged commit 461d2c8 into Automattic:develop Aug 8, 2024
@szepeviktor
Copy link
Contributor Author

Glad to contribute.

@GaryJones
Copy link
Contributor

Wonderful - thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: awaiting feedback Awaiting feedback from reporter type: maintenance Routine maintenance and code quality improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants