Send empty set when search yields no results#82
Merged
GaryJones merged 1 commit intoAutomattic:mainfrom Aug 8, 2024
Merged
Conversation
GaryJones
approved these changes
Aug 8, 2024
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a search for content yields no results, Zoninator exits without sending a response. jQuery interprets this response to represent a failed request (I believe because it interprets it as malformed JSON) and never fires the "success" callback that removes the loading spinner, making it look to the user as though they're still waiting for search results. Sending an empty array back to the browser appears to address this issue.