Closed
Conversation
WP_CLI::error() exits the process immediately, so the subsequent echo $e->getMessage() line was dead code that never executed. This meant the actual SQL error details were never shown to users. Now includes the exception message in the WP_CLI::error() call so users can see what specifically went wrong (e.g., "syntax error near X"). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WP_CLI::error()exits the process immediately, so the subsequentecho $e->getMessage()was dead codeProblem
When importing a SQL file with syntax errors, users would see:
But they wouldn't see what the actual error was (e.g., "syntax error near X").
Solution
Include the exception message in the
WP_CLI::error()call:Test plan
INSERT INTO foo VALUES (unclosed parenthesis;)wp sqlite import invalid.sql🤖 Generated with Claude Code