Site settings: prevent console price formatting warnings

[ciampo]

Proposed Changes

• Change the computation of the agency billing message and its dependencies to be lazier

Why are these changes being made?

Currently, the price (that is displayed in the agency billing message) is compute every render.
When there's no agency associated to the site, this causes the browser console to be flooded with warnings.

Those warnings should pollute the browser console and should actually only be shown when the price needs to be calculated/displayed.

Note

The code in this page is quite messy, mixing logic about "untangled"/"tangled" sites, a4a and non-a4a site, and other forks in the logic. I tried to keep the scope of this PR as focused as possible on solving the warnings, but this file would definitely benefit from a refactor.

Testing Instructions

• Load a simple site's settings page (ie. /settings/general/{SITE_SLUG}, make sure that:
  • the page looks and behaves as expected
  • the browser console doesn't show warnings about the value and currency not being defined correctly

• Test that the billing message is displayed correctly for a4a development sites:
  • Create an A4A development site (I followed instructions from pdtkmj-2Te-p2 )
  • In calypso WPCom environment, visit settings/general/{A4A_DEV_SITE_SLUG}
  • Make sure that the page behaves and looks as expected. In particular, check that:
    • the "Launch site" and "Refer to client" buttons work as expected;
    • the billing message is shows correctly next to the "launch site" button
    • when clicking the "Launch site" button, a modal is shown with the same billing message as its contents

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-131652

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-131652&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-131652&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~42 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
site-settings       +131 B  (+0.0%)      +42 B  (+0.0%)
settings            +131 B  (+0.0%)      +42 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[ivan-ottinger]

Thank you for this fix and the review request, @ciampo.

The proposed changes look good to me. I can confirm the warning isn't displaying.

I haven't noticed any regressions when testing with either non-A4A or A4A sites. The modal is loading price correctly and the buttons work as expected:

The code in this page is quite messy, mixing logic about "untangled"/"tangled" sites, a4a and non-a4a site, and other forks in the logic. I tried to keep the scope of this PR as focused as possible on solving the warnings, but this file would definitely benefit from a refactor.

I remember it wasn't fun indeed when we worked on the A4A-related changes on this page. It caters to many different cases. I suspect that could have contributed to us missing the warning before.

[ciampo]

Thank you for testing, @ivan-ottinger ! I pushed a couple of commits to address feedback, could you take another look to make sure everything keeps working as expected?

[tyxla]

This LGTM from my perspective 👍

Thanks for improving the price logic, looks so much cleaner now!

[ivan-ottinger]

Thank you for testing, @ivan-ottinger ! I pushed a couple of commits to address feedback, could you take another look to make sure everything keeps working as expected?

I have reviewed the latest changes and tested the PR again and haven't noticed any issues. 👌🏼🙂

(tested with Simple, Atomic A4A, Atomic non-A4A sites)