Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Odie] Give Wapuu a chance #98419

Merged

Conversation

AllTerrainDeveloper
Copy link
Contributor

@AllTerrainDeveloper AllTerrainDeveloper commented Jan 15, 2025

Proposed Changes

Adds experiment code changes for 'give_wapuu_a_chance_odie'

Why are these changes being made?

  • Adds several changes for the user: Stop conflating the negative rating with the direct escalation path
  • Stops showing the direct escalation link unless user has asked a question that might be solvable or not by the AI

Testing Instructions

  1. Adding yourself the experiment mentioned above
  2. Open a new conversation and ask the assistant to get to contact support directly
  3. Assert that it asks you to first describe the issue
  4. (If you want, try to keep cheating to get the user support without adding context to your issue)
  5. Assert that once you gave enough context, you can already ask for human support and get the button for contacting human support
  6. Assert that the button for escalating does not how up anymore when rating negatively a message

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Jan 15, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug Odie/restrict-escalation-until-enough-context on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Jan 15, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~222 bytes added 📈 [gzipped])

name                                       parsed_size           gzip_size
async-load-automattic-help-center-stepper       +677 B  (+0.1%)     +222 B  (+0.1%)
async-load-automattic-help-center               +677 B  (+0.1%)     +222 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@AllTerrainDeveloper AllTerrainDeveloper self-assigned this Jan 16, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 16, 2025
@AllTerrainDeveloper AllTerrainDeveloper marked this pull request as ready for review January 16, 2025 12:59
Copy link
Contributor

@marco-altran marco-altran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Did some basic testing and the behavior looks right. Just have a question and one code suggestion.

@@ -36,6 +38,9 @@ export const MessageContent = ( {
isNextMessageFromSameSender && 'next-chat-message-same-sender'
);

const stopConflatingNegativeRatingWithContactSupport =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great naming!

@AllTerrainDeveloper
Copy link
Contributor Author

@marco-altran While explaining you the behavior of the status array, I discovered a bug and I have fixed it in the use-autoscroll.ts file

Here the wrong and the right behaviour

https://github.com/user-attachments/assets/efee3692-dd30-478d-8427-0f8625d68fe5
https://github.com/user-attachments/assets/811ef588-ad52-4107-8aa1-b84a7d78803f

Copy link
Contributor

@marco-altran marco-altran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't found any issues, let's go! Feel free to deploy it.

@AllTerrainDeveloper AllTerrainDeveloper force-pushed the Odie/restrict-escalation-until-enough-context branch from 070e314 to 492555b Compare January 24, 2025 13:47
Copy link
Contributor

@marco-altran marco-altran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code works! Tested with experiment group and control group. Let's go 🚀

@AllTerrainDeveloper AllTerrainDeveloper merged commit 7cc0499 into trunk Jan 24, 2025
13 checks passed
@AllTerrainDeveloper AllTerrainDeveloper deleted the Odie/restrict-escalation-until-enough-context branch January 24, 2025 17:49
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants