-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Odie] Give Wapuu a chance #98419
[Odie] Give Wapuu a chance #98419
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Async-loaded Components (~222 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Did some basic testing and the behavior looks right. Just have a question and one code suggestion.
@@ -36,6 +38,9 @@ export const MessageContent = ( { | |||
isNextMessageFromSameSender && 'next-chat-message-same-sender' | |||
); | |||
|
|||
const stopConflatingNegativeRatingWithContactSupport = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great naming!
@marco-altran While explaining you the behavior of the status array, I discovered a bug and I have fixed it in the Here the wrong and the right behaviour https://github.com/user-attachments/assets/efee3692-dd30-478d-8427-0f8625d68fe5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't found any issues, let's go! Feel free to deploy it.
070e314
to
492555b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code works! Tested with experiment group and control group. Let's go 🚀
Proposed Changes
Adds experiment code changes for
'give_wapuu_a_chance_odie'
Why are these changes being made?
Testing Instructions
Pre-merge Checklist