Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E tests: skip flaky Woo signup test #98057

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

bluefuton
Copy link
Contributor

@bluefuton bluefuton commented Jan 8, 2025

Proposed Changes

Skip flaky test for the moment so we can restart deploys.

Discussion: p1736288516678589-slack-C02DQP0FP

Why are these changes being made?

  • The test is part of the pre-release test suite, and is preventing PRs from being shipped.

Testing Instructions

cd test/e2e && yarn jest specs/onboarding/signup__woo-email.ts

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@bluefuton bluefuton self-assigned this Jan 8, 2025
@bluefuton
Copy link
Contributor Author

Test results:

Screenshot 2025-01-08 at 16 01 38

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@bluefuton bluefuton merged commit fbc42bb into trunk Jan 8, 2025
13 checks passed
@bluefuton bluefuton deleted the skip/flaky-e2e-signup-test branch January 8, 2025 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants