Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust help center unread icon #97984

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Adjust help center unread icon #97984

merged 1 commit into from
Jan 6, 2025

Conversation

heavyweight
Copy link
Contributor

Before After
FQUTDv.gif 0enPwq.gif
FOeUKP.gif I7Vsmt.gif />

Related to #
#97930

Proposed Changes

  • Adjust help center unread icon to match unread notification size

Why are these changes being made?

  • The help center unread icon should match better the unread notification circle
  • This PR adjusts the size, position and stroke color of the circle of the help center icon

Testing Instructions

  • Test in wp-calypso and wp-admin how the unread indicator of the help center icon looks

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@heavyweight heavyweight added the [Feature] Help Center The new integrated Help Center in Calypso that provides support tools on all screens. label Jan 6, 2025
@heavyweight heavyweight self-assigned this Jan 6, 2025
@heavyweight heavyweight requested a review from a team as a code owner January 6, 2025 11:43
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 6, 2025
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@escapemanuele escapemanuele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@escapemanuele escapemanuele merged commit 0b0ff0a into trunk Jan 6, 2025
14 of 15 checks passed
@escapemanuele escapemanuele deleted the fix/hc-unread-icon branch January 6, 2025 13:46
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Help Center The new integrated Help Center in Calypso that provides support tools on all screens.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help Center: Dot icon in navbar is smaller than the Notification one
3 participants