Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hosting dashboard: Rework site logs header and toolbar #97694

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

fredrikekelund
Copy link
Contributor

@fredrikekelund fredrikekelund commented Dec 20, 2024

Fixes #96792

Proposed Changes

This PR reworks the header and toolbar in the logs tab in the hosting dashboard per @fditrapani's design in #96792. Summary:

  • Move the Download logs button to the header
  • Use ToggleGroupControl from @wordpress/components for the log type switcher
  • Move the labels above the controls (instead of to the left, as they previously were)
  • Improve alignment of auto-refresh toggle
  • General CSS cleanup
New Old
logs-php-new logs-php-old
logs-web-new logs-web-old

Why are these changes being made?

See #96792

Testing Instructions

  1. Have a >=Business site
  2. Navigate to /site-logs/:site_slug/php
  3. Ensure that the page looks good and that the filter controls (including auto-refresh) works as expected
  4. Ensure that the Download logs button works as expected
  5. Switch to Web server logs
  6. Ensure that the page looks good and that the filter controls works as expected
  7. Shrink the viewport to mobile and ensure that things still work as expected
  8. Navigate to /sites/tools/logs/:site_slug/php
  9. Ensure that the page looks good in this context, too

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@fredrikekelund fredrikekelund requested review from fditrapani and a team December 20, 2024 11:56
@fredrikekelund fredrikekelund self-assigned this Dec 20, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 20, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug f26d/site-logs-header-rework on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Dec 20, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~67 bytes added 📈 [gzipped])

name        parsed_size           gzip_size
site-logs        +365 B  (+0.0%)      +39 B  (+0.0%)
site-tools       +287 B  (+0.0%)      +28 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@fredrikekelund
Copy link
Contributor Author

👋 @fushar, I'd appreciate a review from you, too, since it looks like you recently worked on /sites/tools/logs/:site_slug/php`

Copy link
Contributor

@fditrapani fditrapani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this! It's mostly looking good. One small issue is when things begin to collapse to the next line, we have multiple breaks:

image

Can we keep it on the same line like this:

image

@fditrapani
Copy link
Contributor

Unrelated to this PR, I see we have 3 different tab group styles across these pages:

image image image

Can someone create a separate issue to consolidate these. I would say the one we're using on this page is the one we should be using on all since it's aligned with core's tab group.

Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On certain smaller width resolution, we have a full-width Download button; not sure if this is intended:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Improve position of Download button in Logs tab
4 participants