-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hosting dashboard: Rework site logs header and toolbar #97694
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~67 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
👋 @fushar, I'd appreciate a review from you, too, since it looks like you recently worked on /sites/tools/logs/:site_slug/php` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #96792
Proposed Changes
This PR reworks the header and toolbar in the logs tab in the hosting dashboard per @fditrapani's design in #96792. Summary:
Download logs
button to the headerToggleGroupControl
from@wordpress/components
for the log type switcherWhy are these changes being made?
See #96792
Testing Instructions
/site-logs/:site_slug/php
Download logs
button works as expectedWeb server
logs/sites/tools/logs/:site_slug/php
Pre-merge Checklist