-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 100-year domain copy #96750
Update 100-year domain copy #96750
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~1518 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17019241 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @fditrapani for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
@@ -155,6 +155,54 @@ export default function InfoModal( { | |||
flowName === HUNDRED_YEAR_DOMAIN_FLOW | |||
? translate( '100-Year Domain' ) | |||
: getPlan( PLAN_100_YEARS )?.getTitle(); | |||
const featureOneTitle = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works and is probably the only way under the current structure. However, it would be better if info-modal
simply shows the copies assigned to it, rather than conditionally showing different copies based on the flow name.
Decoupling this is non-trivial though.
- We'd need to extract the mechanism of customizing step wrapper component: https://github.com/Automattic/wp-calypso/blob/trunk/client/landing/stepper/declarative-flow/internals/steps-repository/domains/index.tsx#L305
- We'd also need to implement the mechanism of passing . In this case, conceptually only
hundred-year-plan
andhundred-year-domain
flows know what to show in the info modal, so those should be configurable right in their flow implementation, e.g. https://github.com/Automattic/wp-calypso/blob/trunk/client/landing/stepper/declarative-flow/hundred-year-domain.ts#L65 .
@alshakero Are there existing ways that we can better structure this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a look @southp. Should we handle restructuring this code in a separate PR? Can we go ahead and merge this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, checked and everything looks good! 👍 Sorry for the delay for this review!
fe73aa5
to
fae424c
Compare
Proposed Changes
This PR adds custom copy for the 100-year domain purchase flow and it fixes a bug on mobile where the foldable card icon is not visible.
Before
After
Why are these changes being made?
We currently have stale copy for the 100-year domains. This PR updates it with new copy.
Testing Instructions
Visit
/setup/hundred-year-domain/domains
and compare against production (wordpress.com/setup/hundred-year-domain/domains
)Pre-merge Checklist