Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 100-year domain copy #96750

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Update 100-year domain copy #96750

merged 1 commit into from
Jan 7, 2025

Conversation

fditrapani
Copy link
Contributor

Proposed Changes

This PR adds custom copy for the 100-year domain purchase flow and it fixes a bug on mobile where the foldable card icon is not visible.

Before
image

image

After
image

image

Why are these changes being made?

We currently have stale copy for the 100-year domains. This PR updates it with new copy.

Testing Instructions

Visit /setup/hundred-year-domain/domains and compare against production (wordpress.com/setup/hundred-year-domain/domains)

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 25, 2024
@fditrapani fditrapani added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Nov 25, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/100-year-domain-content on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Nov 25, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1518 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
update-design-flow        +1032 B  (+0.1%)     +466 B  (+0.2%)
link-in-bio-tld-flow      +1032 B  (+0.1%)     +482 B  (+0.1%)
copy-site-flow            +1032 B  (+0.2%)     +464 B  (+0.3%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@a8ci18n
Copy link

a8ci18n commented Nov 25, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17019241

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @fditrapani for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Dec 1, 2024

Translation for this Pull Request has now been finished.

@@ -155,6 +155,54 @@ export default function InfoModal( {
flowName === HUNDRED_YEAR_DOMAIN_FLOW
? translate( '100-Year Domain' )
: getPlan( PLAN_100_YEARS )?.getTitle();
const featureOneTitle =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works and is probably the only way under the current structure. However, it would be better if info-modal simply shows the copies assigned to it, rather than conditionally showing different copies based on the flow name.

Decoupling this is non-trivial though.

@alshakero Are there existing ways that we can better structure this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look @southp. Should we handle restructuring this code in a separate PR? Can we go ahead and merge this?

@fditrapani fditrapani removed the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Dec 11, 2024
Copy link
Contributor

@leonardost leonardost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked and everything looks good! 👍 Sorry for the delay for this review!

@fditrapani fditrapani removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 7, 2025
@fditrapani fditrapani force-pushed the add/100-year-domain-content branch from fe73aa5 to fae424c Compare January 7, 2025 15:33
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 7, 2025
@fditrapani fditrapani merged commit c50f158 into trunk Jan 7, 2025
12 checks passed
@fditrapani fditrapani deleted the add/100-year-domain-content branch January 7, 2025 16:02
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants