Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: add FlowQuestion component #96235

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

simison
Copy link
Member

@simison simison commented Nov 11, 2024

In #96143 I started moving around "flow question" component from onboarding into Calypso subscriber management screen.

The component is going to be used in "add subscribers" modal:

Screenshot 2024-11-11 at 15 53 39

Next up I'd use the component in onboarding (replace existing FlowCard component used mostly in migration flows) and in subscription management.

There could be better alternative name than "FlowQuestion"

There's something wrong with Badge sub-component, but I think it's styles leaking from surrounding code into the component. Should be good to fix in another PR.

Proposed Changes

  • Add "FlowQuestion" component.

Why are these changes being made?

Testing Instructions

  • Just code review at this point.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@simison simison added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Components New Component Adds a new common UI component labels Nov 11, 2024
@simison simison requested a review from lezama November 11, 2024 14:12
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/components-flow-question on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Components New Component Adds a new common UI component [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants