Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans: fix the horizontal overflow when the text in a comparison cell is too long. #95427

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

southp
Copy link
Contributor

@southp southp commented Oct 16, 2024

Related to #91870

Proposed Changes

Currently, a longer text can overflow a comparison grid cell and cause layout breakage. The most notable case reported in #91870 is de. This PR fixes the issue by introducing text-wrap and hyphens CSS properties:

Before:

CleanShot.2024-10-16.at.18.40.40.mp4

After:

CleanShot.2024-10-16.at.18.38.37.mp4

Why are these changes being made?

While the case caught our attention is de, it's a general layout configuration issue whenever a copy is long and can't be broken up easily by the browser. Introducing pretty text wrapping and auto-hyphening is not perfect, but can prevent layout breakage from happening again.

Testing Instructions

  • On a mobile resolution, confirm that the eCommerce features
  • Repeat the same on a few more locales.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@southp southp added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 16, 2024
@southp southp requested a review from a team October 16, 2024 10:51
@southp southp self-assigned this Oct 16, 2024
@southp southp requested a review from a team as a code owner October 16, 2024 10:51
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/comparison-grid-feature-text-overflow on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants