Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader Onboarding: Add "Step 2" Initial Styling #95414

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

DustyReagan
Copy link
Member

@DustyReagan DustyReagan commented Oct 15, 2024

Related to https://github.com/Automattic/loop/issues/188

Proposed Changes

  • This PR adds the initial styling for the "Step 2" modal
  • It also disables "Step 2" on the banner if "Step 1" (following 3 or more tags) is not completed.
Before After
Screenshot 2024-10-16 at 11 33 20 AM Screenshot 2024-10-16 at 11 33 11 AM

Why are these changes being made?

  • Push Reader Onboarding project forward.

Testing Instructions

  • Go to /read?flags=reader/onboarding
  • Click on step 2 of the onboarding banner
  • View the new sytyling

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@DustyReagan DustyReagan changed the title Add preview column Reader Onboarding: Add preview column Oct 15, 2024
@matticbot
Copy link
Contributor

matticbot commented Oct 15, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/style-to-discover-sites on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Oct 15, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~111 bytes added 📈 [gzipped])

name    parsed_size           gzip_size
reader       +617 B  (+0.1%)     +111 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@DustyReagan DustyReagan marked this pull request as ready for review October 16, 2024 16:23
@DustyReagan DustyReagan requested a review from a team as a code owner October 16, 2024 16:23
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 16, 2024
@DustyReagan DustyReagan changed the title Reader Onboarding: Add preview column Reader Onboarding: Add "Step 2" Inital Styling Oct 16, 2024
@DustyReagan DustyReagan changed the title Reader Onboarding: Add "Step 2" Inital Styling Reader Onboarding: Add "Step 2" Initial Styling Oct 16, 2024
@DustyReagan DustyReagan self-assigned this Oct 16, 2024
@DustyReagan DustyReagan merged commit 7ce1a55 into trunk Oct 16, 2024
14 of 15 checks passed
@DustyReagan DustyReagan deleted the add/style-to-discover-sites branch October 16, 2024 18:37
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 16, 2024
@a8ci18n
Copy link

a8ci18n commented Oct 16, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16913804

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @DustyReagan for including a screenshot in the description! This is really helpful for our translators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants