display the total clicks and total impressions in advertising pages

[therocket-gr]

Related to #

Proposed Changes

2638-gh-tumblr/a8c-dsp

Why are these changes being made?

we want to add a total impressions and total clicks (for all campaigns) for a user in the advertising pages (both in ready to promote and campaigns page)

the added elements look like this (ss from browser)

and ss from figma

please note that I haven't added the icons for more info (the ones with the 'i') but I am missing the context of what will happen if hovered ( I guess we need some kind of popover with some additional messages)

Update:

I added a function to format large numbers properly..

as we have users who might have very large numbers of campaigns and their impressions (maybe also clicks) can be added to have millions of results

now for example 100000 will be displayed as 100K 125500 will be displayed as 125.5K

1000000 will be displayed as 1M

1255000 will be displayed as 1.255M and so on (for millions I added 3 decimals to have some better understanding of the amount)

to test this you can just hardcode the line

totalClicks={ campaignsStats?.total_clicks }

to
totalClicks={ 1500000 }
in

client/my-sites/promote-post-i2/main.tsx

Testing Instructions

please check out the branch (or test the preview links) check that the elements appear as expected
(I checked the layout both when we do have a banner and when we don't.. you can also test by hardcoding this line
const showBanner = ! campaignsIsLoading && ( totalCampaignsUnfiltered || 0 ) < 3; and change it to showBanner = true or false accordingly

test that the layout looks ok in tablet and mobile..

do a CR.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Link to live branch is being generated...
Please wait a few minutes and refresh this page.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• blaze-dashboard
• odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug vdimitrakis/2638-display-total-impressions-and-clicks-in-advertising-pages on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~574 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
promote-post-i2      +1094 B  (+0.3%)     +262 B  (+0.2%)
stats                 +221 B  (+0.0%)     +110 B  (+0.0%)
posts-custom          +221 B  (+0.0%)     +102 B  (+0.0%)
posts                 +221 B  (+0.0%)     +102 B  (+0.0%)
pages                 +221 B  (+0.0%)     +100 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[sbarbosa]

Hi @therocket-gr!
I found a couple of things that we need to change, but overall, the changes look great and worked as expected.

[sbarbosa]

LGTM 👍

[jjolmo]

LGTM

[sbarbosa]

I searched in Calypso, and I found this function that do a similar thing:
https://github.com/Automattic/wp-calypso/tree/trunk/client/lib/format-number-compact

Do you think we could use that one instead? It might behave differently, which is what you wanted to achieve here.

[therocket-gr]

the function is a bit strange.. it wont format millions properly. i tested and I think my method works better. i just added a small improvement to add locale formatting in the number (so for some countries that use comma instead of a point for decimals it will display the result better)