Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup experiment code #95311

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Cleanup experiment code #95311

merged 1 commit into from
Oct 16, 2024

Conversation

niranjan-uma-shankar
Copy link
Contributor

@niranjan-uma-shankar niranjan-uma-shankar commented Oct 11, 2024

Proposed Changes

  • I noticed that the signup page still fires the experiment assignment API for calypso_signup_onboarding_deemphasize_free_plan. Since this experiment is no longer active, we can remove the code.

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 11, 2024
@niranjan-uma-shankar niranjan-uma-shankar requested a review from a team October 11, 2024 10:35
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/remove-old-exp on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~68 bytes removed 📉 [gzipped])

name                  parsed_size           gzip_size
update-design-flow         +122 B  (+0.0%)      -63 B  (-0.0%)
signup                     +122 B  (+0.0%)      -59 B  (-0.1%)
link-in-bio-tld-flow       +122 B  (+0.0%)      -62 B  (-0.0%)
onboarding-flow             -27 B  (-0.2%)       -2 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~2666 bytes added 📈 [gzipped])

name                                             parsed_size           gzip_size
async-load-signup-steps-plans-theme-preselected      +6831 B  (+1.8%)    +2666 B  (+2.1%)
async-load-signup-steps-plans                        +6831 B  (+1.8%)    +2666 B  (+2.1%)
async-load-signup-steps-page-picker                  +6831 B  (+1.9%)    +2666 B  (+2.3%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@southp southp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning it up. LGTM 🚢

@niranjan-uma-shankar niranjan-uma-shankar merged commit 7b6dc0e into trunk Oct 16, 2024
16 checks passed
@niranjan-uma-shankar niranjan-uma-shankar deleted the fix/remove-old-exp branch October 16, 2024 12:40
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants