Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add We’ll take it from here! step when user tries to migrate a wpcom site #95294

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

gabrielcaires
Copy link
Contributor

@gabrielcaires gabrielcaires commented Oct 10, 2024

Closes #95293

Proposed Changes

  • Add a step to provide user info about the HE's next steps after the user provide information about their goals
  • Connect the step with the migration and site-migration flows, after the user submits the form

Note

There is another scenario we should display this screen It will be implemented as part of task #95293 but the content is already available on this PR.

Testing Instructions

  • Go to /setup/migration flow
  • Follow all steps until reach the credentials step
  • Set a site that is already hosted on wordpress.com (E.g. [any site].wpcomstaging.com)
  • Set any goal option on the Your site is already on WordPress.com
  • Check if you can see the new step as the image above (Please pay attention if the subtitle is the same as the screenshot because there is another variation that will be connected to another scenario in a further PR.
  • Check the links

image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@gabrielcaires gabrielcaires self-assigned this Oct 10, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 10, 2024
@gabrielcaires gabrielcaires requested a review from a team October 10, 2024 17:49
@matticbot
Copy link
Contributor

matticbot commented Oct 10, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~63 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-subscriptions         +357 B  (+0.0%)      +72 B  (+0.0%)
entry-stepper               +357 B  (+0.0%)      +63 B  (+0.0%)
entry-main                  +357 B  (+0.0%)      +66 B  (+0.0%)
entry-login                 +357 B  (+0.0%)      +72 B  (+0.0%)
entry-domains-landing       +357 B  (+0.1%)      +72 B  (+0.0%)
entry-browsehappy           +357 B  (+0.2%)      +72 B  (+0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~815 bytes added 📈 [gzipped])

name                        parsed_size           gzip_size
entrepreneur-flow                +941 B  (+0.7%)      +86 B  (+0.3%)
migration-flow                   +788 B  (+1.1%)      +59 B  (+0.4%)
site-migration-flow              +762 B  (+1.2%)      +44 B  (+0.5%)
hosted-site-migration-flow       +762 B  (+1.2%)      +44 B  (+0.4%)
with-theme-assembler-flow        +760 B  (+1.1%)      +38 B  (+0.3%)
update-options-flow              +760 B  (+1.4%)      +37 B  (+0.6%)
update-design-flow               +760 B  (+0.1%)      +46 B  (+0.0%)
trial-wooexpress-flow            +760 B  (+1.4%)      +35 B  (+0.5%)
tailored-ecommerce-flow          +760 B  (+1.3%)      +39 B  (+0.6%)
site-setup-wg                    +760 B  (+0.8%)      +42 B  (+0.2%)
site-setup-flow                  +760 B  (+0.8%)      +42 B  (+0.2%)
readymade-template-flow          +760 B  (+0.6%)      +38 B  (+0.1%)
migration-signup                 +760 B  (+1.3%)      +38 B  (+0.5%)
import-flow                      +760 B  (+1.2%)      +37 B  (+0.4%)
free-post-setup-flow             +760 B  (+1.5%)      +37 B  (+0.6%)
free-flow                        +760 B  (+1.1%)      +38 B  (+0.3%)
assembler-first-flow             +760 B  (+0.9%)      +40 B  (+0.3%)
ai-assembler-flow                +760 B  (+0.9%)      +39 B  (+0.3%)
import-hosted-site-flow          +181 B  (+0.0%)      +78 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~48 bytes added 📈 [gzipped])

name                                    parsed_size           gzip_size
async-load-signup-steps-initial-intent       +181 B  (+0.2%)      +48 B  (+0.2%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@gabrielcaires gabrielcaires changed the title Site Migration: Add We’ll take it from here! step when user tries to migrate a wpcom site Add We’ll take it from here! step when user tries to migrate a wpcom site Oct 10, 2024
@gabrielcaires gabrielcaires marked this pull request as ready for review October 10, 2024 18:20
@gabrielcaires gabrielcaires requested a review from a team as a code owner October 10, 2024 18:20
Copy link
Contributor

@andres-blanco andres-blanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found two details that might be worth taking a look:

  • Clicking on the Explore features link takes you to the site that was created during the flow. Shouldn't this direct you to your existing WPCOM site?
  • There's a style jump in the width of the link cards when coming back from /home.

This behaviours can be seen in this video:

Screen.Recording.2024-10-14.at.14.38.52.mov

Copy link
Contributor

@Imran92 Imran92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @gabrielcaires !

Looks good and works well overall!

However, I've noticed the following two issues-

  1. No spacings in the sides in the mobile view
Screenshot 2024-10-15 at 8 12 34 AM
  1. Though className is added as an optional property, we don't check if it's actually provided before adding classes prefixed by it. Resulting in undefined classnames in other steps
Screenshot 2024-10-15 at 8 40 59 AM

@gabrielcaires
Copy link
Contributor Author

gabrielcaires commented Oct 15, 2024

@Imran92 both fixed here 1a25921

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/migration-support-instructions on your sandbox.

@gabrielcaires
Copy link
Contributor Author

Clicking on the Explore features link takes you to the site that was created during the flow. Shouldn't this direct you to your existing WPCOM site?

I am unsure; I copied it from another similar button, but I also think they can explore another feature from the new site(!?)

Both solutions are acceptable.
@fditrapani What was your intent?

@gabrielcaires
Copy link
Contributor Author

@andres-blanco
I updated the branch with changes that probably fixed it.
Could you please try again?

css.mov

@gabrielcaires gabrielcaires requested review from Imran92 and removed request for a team October 15, 2024 17:15
Copy link
Contributor

@Imran92 Imran92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Deferring the approval to @andres-blanco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automated Migration i4 [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add We’ll take it from here! step when user tries to migrate a wpcom site
4 participants