-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable user to import a site that is not using WordPress as platform #95246
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~227 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~14104 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~121 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
...ive-flow/internals/steps-repository/site-migration-credentials/hooks/use-credentials-form.ts
Show resolved
Hide resolved
...ive-flow/internals/steps-repository/site-migration-credentials/hooks/use-credentials-form.ts
Show resolved
Hide resolved
isFetching: isAnalyzingUrl, | ||
data: siteInfo, | ||
isSuccess, | ||
} = useAnalyzeUrlQuery( from, shouldAnalyzeUrl ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It only runs the site analyzes when the platform is not available on the URL.
It is necessary because when the user uses the back button on some importing page, we lose the platform name.
So, instead of updating all importer options (WPCOM and WPorg), I just made the step analysis again.
...ive-flow/internals/steps-repository/site-migration-credentials/hooks/use-credentials-form.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gabrielcaires ! Nice work on this. Most of the things works nicely.
However, I've left some optional comments on code and have noticed some hiccups in the following scenarios -
- The back button doesn't work on the this page -
- We are showing the platform name's index, not the user-friendly version, like 'squarespace' instead of 'Squarespace'. I think we should map them to the user-friendly name. Maybe we can reuse this?
- If the platform is Wix, it doesn't take me to an importer, rather it shows a screen with a loader indicating import has already started, without me providing any backup file or anything like that-
...tive-flow/internals/steps-repository/site-migration-other-platform-detected-import/index.tsx
Outdated
Show resolved
Hide resolved
...tive-flow/internals/steps-repository/site-migration-other-platform-detected-import/index.tsx
Outdated
Show resolved
Hide resolved
client/landing/stepper/declarative-flow/migration/helpers/index.ts
Outdated
Show resolved
Hide resolved
I don't have the context, but it is intentional in all places we are running importers wp-calypso/client/landing/stepper/declarative-flow/internals/steps-repository/import/helper.ts Lines 34 to 38 in 23fdaae
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
That's interesting 🤔 Out of curiosity, I checked our cc: @fditrapani Also, as per our discussion here (p1729052919758479/1728407315.083759-slack-C07G7FG6J8Y), can we send a request to the backend API with |
Related to #94914
Proposed Changes
other-platform-detected-import
step to site-migration and migration flowWhy are these changes being made?
Testing Instructions
Scenario: Importing content
/setup/migration
and follow the steps until you reach the credential stepScenario: Importing content
/setup/migration
and follow the steps until you reach the credential stepWe'll take it from here!
stepNote
We are planning to update the
We'll take it from here!
step to be more contextual by case, it will be done in further PRs.Please test, the same scenarios are applicable to the
/setup/site-migration
flowPre-merge Checklist