-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable reactfied lost password form on the core profiler connection page #95002
Enable reactfied lost password form on the core profiler connection page #95002
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~108 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~64 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that the behavior of signup on the core profiler connection page is different from WCCOM and WPCOM. When a user enters an email that already exists on WCCOM and WPCOM, they are redirected to the login page. Should we have the same behavior on core profiler?
Screen.Recording.2024-09-30.at.11.10.15.mov
Screen.Recording.2024-09-30.at.11.10.30.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well but left a comment
client/blocks/signup-form/index.jsx
Outdated
href="/" | ||
onClick={ ( event ) => { | ||
event.preventDefault(); | ||
recordTracksEvent( 'calypso_login_reset_password_link_click' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing this tracks being used by other login pages. Should we use calypso_signup_reset_password_link_click
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilyasfoo Good catch! Updated in Use different track name
@chihsuan Good catch! I think we can handle that in a separate PR. I've created #95070 issue. |
client/blocks/signup-form/index.jsx
Outdated
pwdResetLink: <a href={ lostPassword( this.props.locale ) } />, | ||
pwdResetLink: isReactLostPasswordScreenEnabled() ? ( | ||
<a | ||
href="/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small accessibility comment - some screenreaders will pick up this href and send the user there instead. Shall we continue using the old non-react url as a fallback?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rjchow good call! Updated it in Use legacy lost password link as a fallback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR enables reactfied lost password form on the core profiler connection page
Proposed Changes
Testing Instructions
config/development.json
and enablewoocommerce/core-profiler-passwordless-auth
feature flag.yarn start
reset your password
link.Pre-merge Checklist