Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable reactfied lost password form on the core profiler connection page #95002

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

moon0326
Copy link
Contributor

This PR enables reactfied lost password form on the core profiler connection page

Proposed Changes

  • Enabled reactfied lost password form.

Testing Instructions

  1. Checkout this branch locally.
  2. Open config/development.json and enable woocommerce/core-profiler-passwordless-auth feature flag.
  3. Run yarn start
  4. Once the build is ready, open this link in an incognito window
  5. Enter your already existing account email and press tab.
  6. You should see "An account with this email already exists. Log in or reset your password" message.
  7. Click on reset your password link.
  8. You should see the reactfied lost password form.
    Screenshot 2024-09-27 at 10 53 22 AM

Screenshot 2024-09-27 at 10 54 07 AM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@moon0326 moon0326 requested review from a team, ilyasfoo and rjchow September 27, 2024 17:54
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 27, 2024
@matticbot
Copy link
Contributor

matticbot commented Sep 27, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~108 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
accept-invite        +3327 B  (+1.9%)     +931 B  (+1.8%)
jetpack-connect       +426 B  (+0.0%)     +108 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~64 bytes added 📈 [gzipped])

name                                     parsed_size           gzip_size
async-load-signup-steps-subscribe-email      +3327 B  (+1.9%)     +931 B  (+1.8%)
async-load-signup-steps-user                  +426 B  (+0.3%)      +64 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the behavior of signup on the core profiler connection page is different from WCCOM and WPCOM. When a user enters an email that already exists on WCCOM and WPCOM, they are redirected to the login page. Should we have the same behavior on core profiler?

Screen.Recording.2024-09-30.at.11.10.15.mov
Screen.Recording.2024-09-30.at.11.10.30.mov

Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well but left a comment

href="/"
onClick={ ( event ) => {
event.preventDefault();
recordTracksEvent( 'calypso_login_reset_password_link_click' );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing this tracks being used by other login pages. Should we use calypso_signup_reset_password_link_click instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilyasfoo Good catch! Updated in Use different track name

@moon0326
Copy link
Contributor Author

moon0326 commented Oct 1, 2024

I noticed that the behavior of signup on the core profiler connection page is different from WCCOM and WPCOM. When a user enters an email that already exists on WCCOM and WPCOM, they are redirected to the login page. Should we have the same behavior on core profiler?

Screen.Recording.2024-09-30.at.11.10.15.mov
Screen.Recording.2024-09-30.at.11.10.30.mov

@chihsuan Good catch! I think we can handle that in a separate PR. I've created #95070 issue.

pwdResetLink: <a href={ lostPassword( this.props.locale ) } />,
pwdResetLink: isReactLostPasswordScreenEnabled() ? (
<a
href="/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small accessibility comment - some screenreaders will pick up this href and send the user there instead. Shall we continue using the old non-react url as a fallback?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@moon0326 moon0326 merged commit 8c7328d into trunk Oct 16, 2024
10 of 11 checks passed
@moon0326 moon0326 deleted the update/enable-react-lost-password-on-signup-page branch October 16, 2024 19:56
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants