Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect user to wp-admin when a site has the “Classic style” after the /hosting flow purchase #94644

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

paulopmt1
Copy link
Contributor

Related to: pet6gk-1yJ-p2#redirect-to-wp-admin

Proposed Changes

  • Sites created in the "Classic style" should redirect to their /wp-admin instead of Calypso home

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@paulopmt1 paulopmt1 requested review from DustyReagan and a team September 17, 2024 21:09
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Sep 17, 2024
@matticbot
Copy link
Contributor

matticbot commented Sep 17, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~72 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-stepper               +517 B  (+0.0%)     +118 B  (+0.0%)
entry-subscriptions         +498 B  (+0.0%)     +123 B  (+0.0%)
entry-login                 +498 B  (+0.0%)     +123 B  (+0.0%)
entry-domains-landing       +498 B  (+0.1%)     +123 B  (+0.1%)
entry-browsehappy           +498 B  (+0.2%)     +123 B  (+0.2%)
entry-main                  +301 B  (+0.0%)      +77 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~6275 bytes added 📈 [gzipped])

name                               parsed_size            gzip_size
transferring-hosted-site-flow         +30564 B  (+50.9%)    +9193 B  (+45.1%)
jetpack-cloud-overview                  +304 B   (+0.1%)     +892 B   (+0.7%)
jetpack-cloud                           +211 B   (+0.1%)     +126 B   (+0.1%)
woocommerce-installation                +108 B   (+0.0%)      +39 B   (+0.0%)
woocommerce                             +108 B   (+0.0%)      +39 B   (+0.0%)
with-theme-assembler-flow               -108 B   (-0.2%)      -37 B   (-0.3%)
update-options-flow                     -108 B   (-0.2%)      -36 B   (-0.6%)
update-design-flow                      -108 B   (-0.0%)      -36 B   (-0.0%)
trial-wooexpress-flow                   -108 B   (-0.2%)      -38 B   (-0.5%)
themes                                  +108 B   (+0.0%)      +42 B   (+0.0%)
theme                                   +108 B   (+0.0%)      +42 B   (+0.0%)
tailored-ecommerce-flow                 -108 B   (-0.2%)      -37 B   (-0.5%)
subscribers                             +108 B   (+0.0%)     +167 B   (+0.1%)
stats                                   +108 B   (+0.0%)      +21 B   (+0.0%)
staging-site                            +108 B   (+0.0%)      +37 B   (+0.0%)
sites-dashboard                         +108 B   (+0.0%)      +37 B   (+0.0%)
site-setup-wg                           -108 B   (-0.1%)      -35 B   (-0.2%)
site-setup-flow                         -108 B   (-0.1%)      -35 B   (-0.2%)
site-purchases                          +108 B   (+0.0%)      +39 B   (+0.0%)
site-performance                        +108 B   (+0.0%)      +37 B   (+0.0%)
site-monitoring                         +108 B   (+0.0%)      +37 B   (+0.0%)
site-migration-flow                     -108 B   (-0.2%)      -37 B   (-0.4%)
site-logs                               +108 B   (+0.0%)      +37 B   (+0.0%)
settings-writing                        +108 B   (+0.0%)      +39 B   (+0.0%)
settings-security                       +108 B   (+0.0%)      +39 B   (+0.0%)
settings-reading                        +108 B   (+0.0%)      +39 B   (+0.0%)
settings-podcast                        +108 B   (+0.0%)      +39 B   (+0.0%)
settings-performance                    +108 B   (+0.0%)      +39 B   (+0.0%)
settings-newsletter                     +108 B   (+0.0%)      +39 B   (+0.0%)
settings-jetpack                        +108 B   (+0.0%)      +39 B   (+0.0%)
settings-discussion                     +108 B   (+0.0%)      +39 B   (+0.0%)
settings                                +108 B   (+0.0%)      +39 B   (+0.0%)
scan                                    +108 B   (+0.0%)      +39 B   (+0.0%)
readymade-template-flow                 -108 B   (-0.1%)      -32 B   (-0.1%)
purchases                               +108 B   (+0.0%)      +39 B   (+0.0%)
promote-post-i2                         +108 B   (+0.0%)      +39 B   (+0.0%)
preview                                 +108 B   (+0.0%)      +39 B   (+0.0%)
posts-custom                            +108 B   (+0.0%)      +38 B   (+0.0%)
posts                                   +108 B   (+0.0%)      +38 B   (+0.0%)
plugins                                 +108 B   (+0.0%)      +37 B   (+0.0%)
plans                                   +108 B   (+0.0%)      +36 B   (+0.0%)
people                                  +108 B   (+0.0%)      +39 B   (+0.0%)
pages                                   +108 B   (+0.0%)      +39 B   (+0.0%)
migration-signup                        -108 B   (-0.2%)      -37 B   (-0.5%)
migration-flow                          -108 B   (-0.1%)      -37 B   (-0.3%)
migrate                                 +108 B   (+0.0%)      +39 B   (+0.0%)
media                                   +108 B   (+0.0%)      +40 B   (+0.0%)
marketplace                             +108 B   (+0.0%)      +32 B   (+0.0%)
marketing                               +108 B   (+0.0%)      +39 B   (+0.0%)
jetpack-social                          +108 B   (+0.0%)      +39 B   (+0.0%)
jetpack-search                          +108 B   (+0.0%)      +39 B   (+0.0%)
jetpack-connect                         +108 B   (+0.0%)      +39 B   (+0.0%)
jetpack-cloud-settings                  +108 B   (+0.0%)      +39 B   (+0.0%)
jetpack-cloud-pricing                   +108 B   (+0.0%)      +39 B   (+0.0%)
jetpack-cloud-plugin-management         +108 B   (+0.0%)      +37 B   (+0.0%)
jetpack-cloud-features-comparison       +108 B   (+0.0%)      +39 B   (+0.0%)
import-flow                             -108 B   (-0.2%)      -37 B   (-0.4%)
import                                  +108 B   (+0.0%)      +36 B   (+0.0%)
hosting-features                        +108 B   (+0.0%)      +37 B   (+0.0%)
hosting                                 +108 B   (+0.0%)      +37 B   (+0.0%)
hosted-site-migration-flow              -108 B   (-0.2%)      -37 B   (-0.4%)
home                                    +108 B   (+0.0%)      +33 B   (+0.0%)
gutenberg-editor                        +108 B   (+0.0%)      +39 B   (+0.0%)
google-my-business                      +108 B   (+0.0%)      +39 B   (+0.0%)
github-deployments                      +108 B   (+0.0%)      +37 B   (+0.0%)
free-post-setup-flow                    -108 B   (-0.2%)      -36 B   (-0.6%)
free-flow                               -108 B   (-0.2%)      -34 B   (-0.3%)
export                                  +108 B   (+0.0%)      +39 B   (+0.0%)
entrepreneur-flow                       -108 B   (-0.1%)      -35 B   (-0.1%)
email                                   +108 B   (+0.0%)      +35 B   (+0.0%)
domains                                 +108 B   (+0.0%)      +39 B   (+0.0%)
customize                               +108 B   (+0.0%)      +39 B   (+0.0%)
concierge                               +108 B   (+0.0%)      +39 B   (+0.0%)
comments                                +108 B   (+0.0%)      +39 B   (+0.0%)
checkout                                +108 B   (+0.0%)      +42 B   (+0.0%)
backup                                  +108 B   (+0.0%)      +38 B   (+0.0%)
assembler-first-flow                    -108 B   (-0.1%)      -33 B   (-0.2%)
ai-assembler-flow                       -108 B   (-0.1%)      -34 B   (-0.2%)
add-ons                                 +108 B   (+0.0%)      +39 B   (+0.0%)
activity                                +108 B   (+0.0%)      +39 B   (+0.0%)
a8c-for-agencies-overview               -103 B   (-0.0%)      -55 B   (-0.0%)
earn                                     -88 B   (-0.0%)    -1123 B   (-0.5%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~686 bytes added 📈 [gzipped])

name                                                                              parsed_size           gzip_size
async-load-calypso-jetpack-cloud-sections-sidebar-navigation-manage-selected-...       +196 B  (+0.2%)     +686 B  (+1.9%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@paulopmt1 paulopmt1 changed the title Redirect user to wp-admin on /hosting flow when a site has the "Classic style" Redirect user to wp-admin when a site has the “Classic style” after the /hosting flow purchase Sep 17, 2024
Copy link
Member

@p-jackson p-jackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spent some time testing the commerce flow, because I thought it was the flow that was using the redirectTo param to take the user through a Woo onboarding flow.
However it doesn't do this in production. Maybe it's not supposed to do this? I suppose it makes sense that someone focused on "hosting" would be more interested in "hosting" than in "selling".

This PR definitely does what it's expected to do: taking the user to wp-admin after creating a hosting site.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/redirect-hosting-flow-to-wp-admin on your sandbox.

@paulopmt1 paulopmt1 merged commit b918534 into trunk Sep 18, 2024
11 checks passed
@paulopmt1 paulopmt1 deleted the update/redirect-hosting-flow-to-wp-admin branch September 18, 2024 16:17
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants