-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redirect user to wp-admin when a site has the “Classic style” after the /hosting flow purchase #94644
Conversation
…admin_interface === wp-admin
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~72 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~6275 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~686 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spent some time testing the commerce flow, because I thought it was the flow that was using the redirectTo
param to take the user through a Woo onboarding flow.
However it doesn't do this in production. Maybe it's not supposed to do this? I suppose it makes sense that someone focused on "hosting" would be more interested in "hosting" than in "selling".
This PR definitely does what it's expected to do: taking the user to wp-admin
after creating a hosting site.
client/landing/stepper/declarative-flow/transferring-hosted-site-flow.ts
Outdated
Show resolved
Hide resolved
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Related to: pet6gk-1yJ-p2#redirect-to-wp-admin
Proposed Changes
Testing Instructions
Here's the hosting flow, local URL: http://calypso.localhost:3000/setup/new-hosted-site/plans?ref=hosting-lp§ion=hero
Pre-merge Checklist