Only add CSS class when truly needed for blogger onboarding

[daledupreez]

Related to:

• WPCOM Block Editor: Consider removing RedirectOnboardingUserAfterPublishingPost #94072
• Add launchpad_screen check in post-publish redirects #90706

Proposed Changes

• This PR removes an unintentional problem introduced by Add launchpad_screen check in post-publish redirects #90706, which resulted in us continuing to hide a post-publish modal even when we're not going to redirect users to the launchpad.
• The specific change is to update the logic so that we only add the blog-onboarding-hide class to the document when we explicitly detect that we're in a specific onboarding use case, and removes it when we are not.
  • A minor side use case is that we shift the logic for the currentPostType select to the main component logic so we can use it to drive the main effect and return before we start subscribing to the data stores for publish state changes.

Why are these changes being made?

• This is intended as an interim fix so that the behaviour is not broken, by at least having the redirect and CSS hiding occur together (and not in many cases). As flagged in WPCOM Block Editor: Consider removing RedirectOnboardingUserAfterPublishingPost #94072, it may be better to remove this component and behaviour altogether as a way of simplifying the user experience and flows.

Testing Instructions

• Create a test site via the /setup/design-first or /setup/start-writing flows.
• Work through the flow until you get to the fullscreen launchpad or you are dropped into the post editor.
• Follow the instructions in this comment to apply the wpcom-block-editor changes from this PR to your WordPress.com sandbox
• Ensure that widgets.wp.com is pointed at your sandbox
• Ensure that you're not caching JS resources via your browser
• If you're in the fullscreen launchpad, select an option like "Write your first post" to load the post editor.
  • If you're already in the post editor, refresh the page
• Add some content to the post, and publish it.
• Verify that you see the "Great progress" modal (see screenshot below)
• Now navigate to /wp-admin/post-new.php?start-writing=true for the test site
• Edit the post, and publish it.
• Verify that you're redirected to the fullscreen launchpad

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• [N/A] Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• [N/A] Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• [N/A] For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-117966

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-117966&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-117966&env=a8c-for-agencies

[matticbot]

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/reinstate-hidden-modal-for-blog-post-publish on your sandbox.

[markbiek]

LGTM!

[daledupreez]

Noting that this was deployed to production in D160061-code.