-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Odie] Better message scroll handling #92910
[Odie] Better message scroll handling #92910
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Async-loaded Components (~481 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
9ecd9a1
to
f89df8e
Compare
I tested this out quite a bit. The differences in behavior seem fairly subtle to me. Overall I do feel like the scrolling is a bit smoother. One difference I noticed is that when clicking on anchor links, the scroll position is frequently a bit different than in production. In some cases it is improved, in other cases it is worse. I tested this using the "related articles" which shows the support documentation in the Wapuu frame. I also tested using long message history, and I think that the scrolling does seem mostly better here. In particular, I found that most of the time, the old scrolling behavior did not include the question, only the answer, and now most of the time the question is also included, which is nice. I looked through the code briefly and nothing strange jumped out at me, but I don't really have that much expertise in this part of our codebase. Wapuu-test-scrolling.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have much to say about the code. The changes all look reasonable to me, but I don't fully understand them.
I tested after the latest changes, and the scrolling as well as the button to the latest messages looks great.
I think this will be a nice improvement to the UX!
Proposed Changes
The scrolling behavior was a bit dumb. This patch addresses some issues with it, and improve the overall UX when dealing with new messages.
Why are these changes being made?
Those changes leads to a better UX
Testing Instructions
Talk to Wapuu and assert that the whole experience is smooth, by smooth I mean that sending a message and receiving it, and also, loading an initial LONG conversation, the scroll behavior is nice and smooth.
Ensure the rest of the chat is working (rating messages, full screen a long message, talk to human messages)