Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy passwordless auth feature for WooCommerce.com #90359

Merged
merged 2 commits into from
May 9, 2024

Conversation

chihsuan
Copy link
Member

@chihsuan chihsuan commented May 7, 2024

Deploy Woo passwordless auth feature for WooCommerce.com

Proposed Changes

  • Remove a/b test code Implement woo passwordless signup AB test #89241
  • Enable the feature for all WooCommerce.com users. For now, we don't enable other flows such as "Core Profiler" because we don't have updated design for those flows yet. We will need to update the design and have more testing before enabling those flows.

Woo Passwordless Signup screen
Screenshot 2024-05-07 at 14 36 05

Woo Passwordless Login screen

Screenshot 2024-05-07 at 14 35 56

Testing Instructions

Setup:

  • Set up woocommerce-start-dev-env
  • Use incognito mode to test the following steps

woocommerce.com:

  • Go to https://woocommerce.com/
  • Click on "Log in" in the top right corner
  • Confirm that you see the new passwordless login screen
  • Click on "Sign up" and confirm that you see the new passwordless sign up screen

woocommerce.com checkout flow

  • Confirm that you see the new passwordless login screen
  • Go back and click on "Sign up" link
  • Confirm that you see the new passwordless sign up screen

Woo Express

  • Go to https://woocommerce.com/start/#/
  • Complete the profiler steps
  • Click on "Try Woo Express for free` button
  • Confirm you see the new passwordless sign up screen

/vendor-signup

Core Profiler

  • Visit this link
  • Confirm you see the existing (email/username/password) Core Profiler screen

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented May 7, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~19710 bytes added 📈 [gzipped])

name                   parsed_size            gzip_size
entry-login              -879883 B  (-38.1%)  -223876 B  (-34.8%)
entry-domains-landing       +537 B   (+0.1%)     +249 B   (+0.1%)
entry-browsehappy           +311 B   (+0.2%)       +9 B   (+0.0%)
entry-subscriptions         +307 B   (+0.0%)    +1181 B   (+0.2%)
entry-stepper               +141 B   (+0.0%)     +573 B   (+0.1%)
entry-main                  +141 B   (+0.0%)     +581 B   (+0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~166 bytes removed 📉 [gzipped])

name    parsed_size           gzip_size
signup      -1115 B  (-0.4%)     -577 B  (-0.8%)
pages         +93 B  (+0.0%)     +411 B  (+0.2%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~57403 bytes added 📈 [gzipped])

name                                                                              parsed_size            gzip_size
async-load-calypso-layout-masterbar-checkout-tsx                                    +115686 B     (new)   +39950 B      (new)
async-load-calypso-blocks-support-article-dialog-dialog                              +90971 B  (+89.2%)   +29107 B   (+88.1%)
async-load-calypso-my-sites-checkout-modal                                           -11516 B   (-1.0%)    -3665 B    (-1.2%)
async-load-calypso-lib-account-settings-helper                                        +6247 B   (+4.2%)    +1599 B    (+3.5%)
async-load-calypso-state-lib-automated-transfer-middleware                            +6185 B  (+30.7%)    +2147 B   (+33.5%)
async-load-calypso-lib-preferences-helper                                             +4150 B  (+94.8%)    +1367 B  (+105.1%)
async-load-signup-steps-page-picker                                                   -3060 B   (-0.8%)    -1187 B    (-1.0%)
async-load-purchase-modal-wrapper                                                     -3060 B   (-0.8%)    -1173 B    (-1.0%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...      -3060 B   (-0.9%)    -1189 B    (-1.1%)
async-load-calypso-lib-react-query-devtools-helper                                    +1528 B     (new)     +684 B      (new)
async-load-calypso-blocks-support-article-dialog                                      +1116 B  (+58.1%)     +297 B   (+33.8%)
async-load-signup-steps-theme-selection                                               -1104 B   (-0.3%)     -361 B    (-0.3%)
async-load-calypso-components-sites-popover                                           -1045 B   (-1.4%)     -363 B    (-1.5%)
async-load-calypso-blocks-login-two-factor-authentication-two-factor-content           +715 B   (+4.0%)     +121 B    (+2.0%)
async-load-calypso-layout-masterbar-drafts-popover                                     -567 B   (-2.1%)     -270 B    (-2.9%)
async-load-calypso-notifications                                                       -513 B   (-0.3%)     -134 B    (-0.3%)
async-load-signup-steps-site-picker                                                    -478 B   (-0.5%)      -88 B    (-0.3%)
async-load-signup-steps-difm-site-picker                                               -478 B   (-0.5%)      -92 B    (-0.3%)
async-load-calypso-lib-network-connection                                              +369 B   (+8.8%)     +146 B    (+9.2%)
async-load-calypso-blocks-qr-code-login                                                +304 B   (+1.6%)      +97 B    (+1.3%)
async-load-signup-steps-clone-point                                                    -285 B   (-0.2%)      -88 B    (-0.2%)
async-load-signup-steps-plans-theme-preselected                                        -191 B   (-0.1%)      -53 B    (-0.0%)
async-load-signup-steps-plans                                                          -191 B   (-0.1%)      -53 B    (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@chihsuan chihsuan self-assigned this May 7, 2024
@chihsuan chihsuan changed the title Deploy Woo passwordless auth feature for WooCommerce.com Deploy passwordless auth feature for WooCommerce.com May 7, 2024
@chihsuan chihsuan requested review from a team, psealock and adrianduffell May 7, 2024 06:48
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 7, 2024
Copy link
Contributor

@moon0326 moon0326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested well 👍 🚀

FYI, I clicked each link and replaced woo.com with my local Calypso link for testing.

Copy link
Contributor

@psealock psealock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is testing well, no issues found 🚢

@chihsuan chihsuan merged commit 264cf6e into trunk May 9, 2024
21 of 23 checks passed
@chihsuan chihsuan deleted the update/deploy-woo-passwordless-auth branch May 9, 2024 01:35
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants