Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled Updates: Improve copy when there are no eligible plugins #90237

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

obenland
Copy link
Member

@obenland obenland commented May 2, 2024

Makes the message a bit easier to understand and includes a call to action.

Related to p1714576596695849-slack-C01A60HCGUA

Proposed Changes

  • Updates string to make it a bit clearer.
Screenshot 2024-05-02 at 4 08 00 PM

Testing Instructions

  • Checkout the branch and navigate to /plugins/scheduled-updates
  • Select a WoA site that only contains managed plugins.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

Makes the message a bit easier to understand and includes a call to action.
@obenland obenland added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 2, 2024
@obenland obenland requested a review from a team May 2, 2024 21:11
@obenland obenland self-assigned this May 2, 2024
@obenland
Copy link
Member Author

obenland commented May 2, 2024

Once approved, let's add the [Status] String Freeze label and wait for translations to complete before merging.

That way we don't introduce an untranslated string into an otherwise translated area of our product.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~21 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
plugins                                +34 B  (+0.0%)      +21 B  (+0.0%)
jetpack-cloud-plugin-management        +34 B  (+0.0%)      +21 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@zaerl zaerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More clear, good work.

@obenland obenland added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants