Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update continue as screen copy for woo.com passwordless login flow #89465

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

chihsuan
Copy link
Member

Tweak the copy. Remove First, as this isn’t part of a flow.

image

@chihsuan chihsuan self-assigned this Apr 12, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/wccom-passwordless-copy on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~6 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
entry-login        +52 B  (+0.0%)       +6 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~11 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
jetpack-connect        +52 B  (+0.0%)      +11 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~9 bytes added 📈 [gzipped])

name                      parsed_size           gzip_size
async-load-design-blocks        +52 B  (+0.0%)       +9 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@chihsuan
Copy link
Member Author

Going to merge this without review since this is just a simple copy change and flow is under feature flag.

@chihsuan chihsuan merged commit fb1aa79 into trunk Apr 12, 2024
12 checks passed
@chihsuan chihsuan deleted the update/wccom-passwordless-copy branch April 12, 2024 04:18
gabrielcaires pushed a commit that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants