Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social login: Catch inaccessible sessionStorage errors #88791

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

ivan-ottinger
Copy link
Contributor

@ivan-ottinger ivan-ottinger commented Mar 22, 2024

Resolves #88792.

Proposed Changes

  • add error handling for cases where sessionStorage is not accessible

Markup on 2024-03-22 at 10:41:20

ℹ️ Since this error is quite infrequent, this PR doesn't wait for the translations to be finished.

Testing Instructions

  1. Check out and build the proposed changes.
  2. Navigate to http://calypso.localhost:3000/start/user-social.
  3. Open browser console and delete sessionStorage by entering delete window.sessionStorage;.
  4. Click on the Continue with Google button.
  5. The error notice should display (as can be seen in the screenshot above).

Pre-merge Checklist`

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@ivan-ottinger ivan-ottinger self-assigned this Mar 22, 2024
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~92 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
jetpack-connect       +331 B  (+0.0%)      +92 B  (+0.0%)
accept-invite         +331 B  (+0.2%)      +92 B  (+0.2%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~92 bytes added 📈 [gzipped])

name                          parsed_size           gzip_size
async-load-signup-steps-user       +331 B  (+0.2%)      +92 B  (+0.2%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@ivan-ottinger ivan-ottinger requested a review from a team March 22, 2024 10:06
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 22, 2024
@yansern
Copy link
Contributor

yansern commented Mar 22, 2024

Followed test instructions and it is as expected.
image

Copy link
Contributor

@yansern yansern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This PR wraps the access of sessionStorage in a try..catch block, and displays an error notice if the error is caught.

@ivan-ottinger ivan-ottinger merged commit 59c6952 into trunk Mar 22, 2024
15 checks passed
@ivan-ottinger ivan-ottinger deleted the add/inaccessible-sessionStorage-error-catch branch March 22, 2024 10:39
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Social Login: Handle inaccessible sessionStorage errors
3 participants