Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wccom_from and oauth2_client_id to Signup getRecordProps() #88789

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

chihsuan
Copy link
Member

@chihsuan chihsuan commented Mar 22, 2024

Proposed Changes

I found that there are no properties in the calypso_signup_step_start event that can filter for Woo or Woo Express only.

This PR adds wccom_from and oauth2_client_id props so that we can analyze Woo Express signup metrics more accurately and use them to expose event properties.

Testing Instructions

  • Set up woo start env
  • Go to wordpress.com
  • Open dev tool > enable logging via window.localStorage.setItem( 'debug', 'calypso:analytics')
  • https://woo.com/start/#/installation
  • Click on Try Woo Express for free
  • Observe that event "calypso_signup_start" called with props
{
    "flow": "wpcc",
    "ref": "oauth2",
    "is_in_hosting_flow": false,
    "wccom_from": "nux",
    "oauth2_client_id": 50916
}
Screenshot 2024-03-22 at 17 17 20
  • Go to https://wordpress.com/start
  • Observe that event "calypso_signup_start" called with wccom_from = null and oauth2_client_id = null

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~41 bytes added 📈 [gzipped])

name    parsed_size           gzip_size
signup       +129 B  (+0.0%)      +41 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@chihsuan chihsuan self-assigned this Mar 22, 2024
@chihsuan chihsuan requested review from a team, ilyasfoo and rjchow March 22, 2024 09:21
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 22, 2024
Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy! Thanks!

@chihsuan chihsuan merged commit 2157290 into trunk Mar 25, 2024
18 checks passed
@chihsuan chihsuan deleted the add/signup-start-props branch March 25, 2024 03:10
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants