Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address woo passwordless UI feedback #88748

Merged
merged 6 commits into from
Mar 22, 2024
Merged

Address woo passwordless UI feedback #88748

merged 6 commits into from
Mar 22, 2024

Conversation

chihsuan
Copy link
Member

Related to #88747

Figma: 4ixWMlzrxllx93tSFsCW6k-fi-10009%3A10044

This PR addressed woo passwordless QA UI feedback

Proposed Changes

  • Decrease the "Continue as User" box border from 2px to 1px.
  • Remove default autofill (blue) styles

Before:
Screenshot 2024-03-21 at 16 22 43

After:

Screenshot 2024-03-21 at 16 22 30

  • Remove SF Pro font from footer text. We're using Inter font now.
  • Redirect to log out if user is already logged in when they click on 'Signup'

Testing Instructions

  • Log in WordPress.com but log out of woo.com

  • Go to woo.com

  • Click on "Log in"

  • Observe that you're on the Continue as User page

  • Confirm that the border is 1px.
    Screenshot 2024-03-21 at 15 35 26

  • Click on Sign in as a different user

  • Auto-fill the Your email or username field

  • Confirm the input background is white

  • Click on "Sign up"

  • Observe that you're redirected to Woo Signup screen.

  • Go to Log in screen

  • Log in with a passwordless account

  • Confirm Didn't get the email? You might want to double check if the email address is associated with your account text font is Inter.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Mar 21, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~42 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
entry-login       +108 B  (+0.0%)      +42 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~43 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
jetpack-connect       +108 B  (+0.0%)      +43 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~40 bytes added 📈 [gzipped])

name                      parsed_size           gzip_size
async-load-design-blocks       +108 B  (+0.0%)      +40 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@chihsuan chihsuan self-assigned this Mar 21, 2024
@chihsuan chihsuan requested review from a team, psealock and rjchow March 21, 2024 08:29
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 21, 2024
Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove SF Pro font from footer text. We're using Inter font now.

The "Inter" font doesn't seem to be available? (screenshot)

Might not be related to this PR, but would be nice to fix this together, the terms text hits window in mobile screens in the login screen (screenshot)

Otherwise tests well, pre-approving 🚢

@chihsuan
Copy link
Member Author

The "Inter" font doesn't seem to be available? (screenshot)

You're right, it's not available. My Chrome extension loaded it, so I didn't notice it was missing. 😅 I imported it in the CSS in 4fae433. Thanks for catching that!

Might not be related to this PR, but would be nice to fix this together, the terms text hits window in mobile screens in the login screen (screenshot)

Fixed in 8e3028c!

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/woo-passwordless-ui on your sandbox.

Copy link
Contributor

@rjchow rjchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@chihsuan chihsuan merged commit 1a5a33c into trunk Mar 22, 2024
11 checks passed
@chihsuan chihsuan deleted the fix/woo-passwordless-ui branch March 22, 2024 11:49
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants