-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address woo passwordless UI feedback #88748
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~42 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~43 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~40 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove SF Pro font from footer text. We're using Inter font now.
The "Inter" font doesn't seem to be available? (screenshot)
Might not be related to this PR, but would be nice to fix this together, the terms text hits window in mobile screens in the login screen (screenshot)
Otherwise tests well, pre-approving 🚢
You're right, it's not available. My Chrome extension loaded it, so I didn't notice it was missing. 😅 I imported it in the CSS in 4fae433. Thanks for catching that!
Fixed in 8e3028c! |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Related to #88747
Figma: 4ixWMlzrxllx93tSFsCW6k-fi-10009%3A10044
This PR addressed woo passwordless QA UI feedback
Proposed Changes
Before:
After:
Testing Instructions
Log in WordPress.com but log out of woo.com
Go to woo.com
Click on "Log in"
Observe that you're on the Continue as User page
Confirm that the border is 1px.
Click on
Sign in as a different user
Auto-fill the
Your email or username
fieldConfirm the input background is white
Click on "Sign up"
Observe that you're redirected to Woo Signup screen.
Go to Log in screen
Log in with a passwordless account
Confirm
Didn't get the email? You might want to double check if the email address is associated with your account
text font isInter
.Pre-merge Checklist