-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkout: Add "Is this purchase for business" checkbox for certain US states #88737
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~3173 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~729 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
I think that I'm going to have to take a different approach. This checkbox is not something that should be attached to a payment method and it doesn't make sense to have it outside of checkout. It should be a question asked anew for each checkout and not inside the billing info step (or inside any step) because that step may be collapsed. It's probably best to put this at the bottom of checkout above the submit button. That means that toggling the box will update the shopping cart (because it needs to be sent as part of the tax info) and may change the price but there's no reason that should not work. |
This approach should now work. |
I agree that the method being used shouldn't matter as the tax is applied to the transaction and where it is being executed from - i.e. if I am in Pennsylvania then I would need to pay PA sales tax (assuming PA has an online sales tax etc etc). So bundling this tax data with the method isn't necessary - just bundling it with the specific cart/transaction when it's completed. But correct me if I am wrong here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW I'm waiting to merge this until we have a plan for the backend support. See https://github.com/Automattic/payments-shilling/issues/1914 |
21f5bca
to
d4063b9
Compare
Proposed Changes
This PR adds a new checkbox to the billing info we collect in checkout for tax purposes for certain US states (OH and CT). It reads "Is this purchase for business?" and will be used to help us collect taxes in those states.
Note
The tax calculation doesn't yet do anything with this information. That will come later.
Depends on D142843-code
Part of https://github.com/Automattic/payments-shilling/issues/1914
Testing Instructions
/me/shopping-cart
requests made by toggling the box include atax.location.is_for_business
property that matches what the checkbox shows.