Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Odie] Send site_id and scroll to the beggining of the message. #88711

Conversation

AllTerrainDeveloper
Copy link
Contributor

@AllTerrainDeveloper AllTerrainDeveloper commented Mar 20, 2024

Proposed Changes

This set of changes is fixing an issue where wpcom server can't infer the current site the user is navigating into. Another issue we are fixing within this patch is the ability to scroll to the beginning of the block, instead of to the end of the message when we receive a message from Wapuu

Testing Instructions

In order to test this change correctly you need to sandbox your wpcom public-api with the patch D142563.

  1. Open a site with multiple blogs and different plans
  2. Open Wapuu via flags (eg, ?flags=wapuu)
  3. Add a logger in the wpcom patch, to log the plan the user is using. (eg, line 512 of the wpcom patch, l($plan);.)
  4. Assert that the plan you are using matches the log
  5. Change to a different site with a different plan
  6. Assert the plan keeps matching the new site.
  7. Assert that the question you receive is visible in the initial part of the message (ie, is not scrolled till the bottom of the message)

@AllTerrainDeveloper AllTerrainDeveloper self-assigned this Mar 20, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 20, 2024
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~27 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
async-load-automattic-help-center       +148 B  (+0.0%)      +27 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@sirino sirino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, ship it!

@AllTerrainDeveloper AllTerrainDeveloper merged commit 4075c8e into trunk Mar 20, 2024
16 checks passed
@AllTerrainDeveloper AllTerrainDeveloper deleted the prismiwi2015/odie/scroll-to-begining-block-send-site_id branch March 20, 2024 12:35
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants