-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update woo passwordless screens #88374
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~220 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~231 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~394 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
fac3512
to
d1dfc35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well, but I have a minor question. 🚢
@@ -25,8 +25,8 @@ class PasswordlessSignupForm extends Component { | |||
static propTypes = { | |||
locale: PropTypes.string, | |||
inputPlaceholder: PropTypes.string, | |||
submitButtonLabel: PropTypes.string, | |||
submitButtonLoadingLabel: PropTypes.string, | |||
submitButtonLabel: PropTypes.oneOfType( [ PropTypes.string, PropTypes.node ] ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why this change is needed? I'm not seeing any consumers passing a node 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we changed the submitButtonLoadingLabel
, I think it would be a bit odd/confusing for these two to have different prop types. So, I changed this to ensure consistency. Does that sound good?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. That makes sense, LGTM!
7418b52
to
ea27cfb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested well 👍 🚀
…le for woo passwordless
ea27cfb
to
adf3549
Compare
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/11603213 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @chihsuan for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
* Fix prop type error * Update social TOS * Update continue as user login form for Woo passwordless * Use isWooPasswordless * Add is-woo-passwordless class at masterbar and update magic login style for woo passwordless * Fix tos * Update style * Update style * Update test snap
We reverted #87931 in #88260, which not only reverted the "Continue as Existing user" screen but also reverted the CSS changes of other passwordless screens.
This PR is to bring back the "Continue as Existing user" screen in passwordless feature flag and also fix the other passwordless screens.
Proposed Changes
wooPasswordless
props name toisWooPasswordless
.Testing Instructions
Please setup woo start env for testing
Passwordless signup
Try Woo Express for free
)Continue as Existing user
"Check your email" screen
Pre-merge Checklist