Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update woo passwordless screens #88374

Merged
merged 9 commits into from
Mar 14, 2024
Merged

Conversation

chihsuan
Copy link
Member

@chihsuan chihsuan commented Mar 11, 2024

We reverted #87931 in #88260, which not only reverted the "Continue as Existing user" screen but also reverted the CSS changes of other passwordless screens.

This PR is to bring back the "Continue as Existing user" screen in passwordless feature flag and also fix the other passwordless screens.

Proposed Changes

  • Bring back the new "Continue as Existing user" screen in passwordless feature flag.
  • Fix the styles of other passwordless screens to match the design.
  • Update Term of Service.
  • Change all wooPasswordless props name to isWooPasswordless.
03  Social Signup 03  Existing user - Logged in 03  Social login - Horizontal layout

Testing Instructions

Please setup woo start env for testing

Passwordless signup

  1. Use incognito mode
  2. Go to the Woo Express site creation flow (https://woo.com/start/#/installation > Try Woo Express for free)
  3. Observe that signup screen matches the design 4ixWMlzrxllx93tSFsCW6k-fi-9483_4315

Continue as Existing user

  1. Log in to WP.com but Log out of Woo.com
  2. Go to the Woo Express site creation flow
  3. Observe that the "Continue as Existing user" screen matches the design (4ixWMlzrxllx93tSFsCW6k-fi-9483%3A13771)

"Check your email" screen

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

Copy link

github-actions bot commented Mar 11, 2024

@chihsuan chihsuan self-assigned this Mar 11, 2024
@chihsuan chihsuan changed the title Update woo passwordless screens WIP: Update woo passwordless screens Mar 11, 2024
@chihsuan chihsuan requested a review from rjchow March 11, 2024 13:48
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 11, 2024
@chihsuan chihsuan requested review from a team and moon0326 March 11, 2024 13:48
@matticbot
Copy link
Contributor

matticbot commented Mar 11, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~220 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
entry-login      +1508 B  (+0.1%)     +220 B  (+0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~231 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
jetpack-connect      +1549 B  (+0.1%)     +231 B  (+0.1%)
accept-invite        +1186 B  (+0.6%)     +156 B  (+0.3%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~394 bytes added 📈 [gzipped])

name                          parsed_size           gzip_size
async-load-design-blocks          +1508 B  (+0.1%)     +243 B  (+0.0%)
async-load-signup-steps-user      +1191 B  (+0.8%)     +151 B  (+0.4%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Mar 11, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/woo-passwordless-screen on your sandbox.

@chihsuan chihsuan force-pushed the update/woo-passwordless-screen branch from fac3512 to d1dfc35 Compare March 12, 2024 03:43
@chihsuan chihsuan changed the title WIP: Update woo passwordless screens Update woo passwordless screens Mar 12, 2024
Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well, but I have a minor question. 🚢

@@ -25,8 +25,8 @@ class PasswordlessSignupForm extends Component {
static propTypes = {
locale: PropTypes.string,
inputPlaceholder: PropTypes.string,
submitButtonLabel: PropTypes.string,
submitButtonLoadingLabel: PropTypes.string,
submitButtonLabel: PropTypes.oneOfType( [ PropTypes.string, PropTypes.node ] ),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why this change is needed? I'm not seeing any consumers passing a node 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we changed the submitButtonLoadingLabel, I think it would be a bit odd/confusing for these two to have different prop types. So, I changed this to ensure consistency. Does that sound good?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. That makes sense, LGTM!

@chihsuan chihsuan force-pushed the update/woo-passwordless-screen branch from 7418b52 to ea27cfb Compare March 13, 2024 05:19
Copy link
Contributor

@moon0326 moon0326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested well 👍 🚀

Base automatically changed from add/woo-passwordless-feature-flag to trunk March 14, 2024 02:32
@chihsuan chihsuan force-pushed the update/woo-passwordless-screen branch from ea27cfb to adf3549 Compare March 14, 2024 02:44
@chihsuan chihsuan merged commit 4a328f9 into trunk Mar 14, 2024
9 of 11 checks passed
@chihsuan chihsuan deleted the update/woo-passwordless-screen branch March 14, 2024 02:52
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 14, 2024
@a8ci18n
Copy link

a8ci18n commented Mar 14, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/11603213

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @chihsuan for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Mar 18, 2024

Translation for this Pull Request has now been finished.

billrobbins pushed a commit that referenced this pull request Mar 20, 2024
* Fix prop type error

* Update social TOS

* Update continue as user login form for Woo passwordless

* Use isWooPasswordless

* Add is-woo-passwordless class at masterbar and update magic login style for woo passwordless

* Fix tos

* Update style

* Update style

* Update test snap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants