Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Woo "Check your email" screen #88013

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

chihsuan
Copy link
Member

@chihsuan chihsuan commented Feb 29, 2024

Related to #87636

Proposed Changes

  • Update the CSS to match the new design 4ixWMlzrxllx93tSFsCW6k-fi-9483%3A8624
  • Remove Jetpack promotion for Woo

Screenshot 2024-02-29 at 14 28 09

Screenshot 2024-02-29 at 14 42 37

Testing Instructions

  • Set up the woocommerce-start-dev-env or use "Calypso Live" link
  • Logout from wordpress.com and woo.com
  • Go to /log-in/link?redirect_to=https%3A%2F%2Fpublic-api.wordpress.com%2Foauth2%2Fauthorize%2F%3Fresponse_type%3Dcode%26client_id%3D50916%26state%3Dcc209140df814f02119fcc56e3662fbb82d946f1631feeca2c5290f408c83029%26redirect_uri%3Dhttps%253A%252F%252Fwoo.com%252Fwc-api%252Fwpcom-signin%253Fnext%253D%25252F%26blog_id%3D0%26wpcom_connect%3D1%26wccom-from%26calypso_env%3Dproduction%26from-calypso%3D1&client_id=50916
  • Enter an email or username (non-a8c account) and click "Send link"
  • Observe that the "Check your email" screen is updated and the Jetpack promotion is removed
  • Please note that the "Open in ..." button is only shown for known domains (gmail, yahoo, aol, apple, outlook)

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@chihsuan chihsuan self-assigned this Feb 29, 2024
@chihsuan chihsuan requested review from a team, adrianduffell and rjchow February 29, 2024 06:43
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 29, 2024
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~7 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
entry-login        +25 B  (+0.0%)       +7 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well, LGTM! 🚢

@chihsuan chihsuan merged commit 02c2989 into trunk Mar 5, 2024
19 checks passed
@chihsuan chihsuan deleted the update/woo-check-your-email-screen branch March 5, 2024 03:38
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants