Upload Plugins: Fix Back Button Infinite Loop #87436
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluefuton
added
the
[Status] Needs Review
|
I think this is a solid change and it's working well! Can you give it a rebase and I'll trigger the tests? I think the PR is old enough that it's not showing up in TeamCity. 🙃 |
|
Done! Thanks for taking a look @sixhours! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
If you currently upload a plugin and there's an error (eg. uploading a ZIP file that contains no plugin), the "Back" button creates an infinite loop because it returns you to that error, and the new upload never finishes. You're forced to restart Calypso.
I think it makes more sense to send folks to the Plugins page, since that's the only screen where they can access the "Upload plugins" button anyway.
Testing Instructions
Go to My Sites > Plugins, and click "Upload plugin" (top right corner). Confirm the "Back" button works, including in the scenario I described above.
cc @lupus2k, @DustyReagan