-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WooCommerce] Fix unable to review Installed Themes in MyTheme tab #86944
Conversation
…nt the page if number is greater than 20
() => | ||
Math.max( | ||
items.findIndex( ( { key } ) => key === selectedKey ), | ||
0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the filter tab doesn't have a match, it should not display any active tab, instead of defaulting to an active index of 0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested well, LGTM! 🚢
Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~20 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
…86944) * Remove the hidden Store filter for My Themes query and do not increment the page if number is greater than 20 * Disable the active state when filter selected key is not found * Reformat * Do not incrementPage when isRequesting or isLastPage * Update client/state/themes/selectors/get-theme-hidden-filters.js Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com> --------- Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>
…86944) * Remove the hidden Store filter for My Themes query and do not increment the page if number is greater than 20 * Disable the active state when filter selected key is not found * Reformat * Do not incrementPage when isRequesting or isLastPage * Update client/state/themes/selectors/get-theme-hidden-filters.js Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com> --------- Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>
Related to #86935
Fix unable to review Installed Themes in MyTheme tab
Please note that it's still not possible to search for themes that are not in .org or wpcom. It seems that the WPCOM's themes API doesn't support it.
Proposed Changes
Store
filter forMy Themes
queryisRequesting
orisLastPage
. This 'incrementPage' will cause an issue where if you directly visit the 'my themes' page through the URL, 'my themes' won't display correctly because 'page' is set to 2.Testing Instructions
Pre-merge Checklist