Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import flows: Refactoring: useQuery instead of redux; update CTA text... #85784

Merged
merged 11 commits into from
Jan 12, 2024
Merged

Import flows: Refactoring: useQuery instead of redux; update CTA text... #85784

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3f8de1f
Rename obsolete "Start building" to "Back to goals" button text
bogiii Dec 26, 2023
63bcab0
Update generateStepPath helper method supporting goals step
bogiii Dec 26, 2023
95c112b
Ready steps: Update logic to allow direct step access
bogiii Dec 27, 2023
9e2ab82
Ready component: Update effect dependencies
bogiii Dec 27, 2023
1b1909e
useAnalyzeUrlQuery: Update stale time to 5 seconds
bogiii Dec 27, 2023
8062d69
site-setup flow: Match goToStep logic with import-focused-flow
bogiii Dec 27, 2023
648eeb3
Capture step: Update logic proving fromUrl as query param
bogiii Dec 27, 2023
eec0618
Capture screen: Get rid of redux connect data; simplify component
bogiii Dec 27, 2023
e7d612a
import-hosted-site flow: fix regression caused by refactoring
bogiii Dec 28, 2023
831fda1
Render component when a urlData object is fetched
bogiii Jan 12, 2024
e41d32c
Fix copy/paste typo
bogiii Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ready component: Update effect dependencies
  • Loading branch information
@bogiii
bogiii committed Jan 11, 2024
commit 9e2ab82ca08ab78f5a3c9b6ec0097ab789c3436e
10 changes: 4 additions & 6 deletions client/blocks/import/ready/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { useSelect, useDispatch } from '@wordpress/data';
import { createElement, createInterpolateElement } from '@wordpress/element';
import { sprintf } from '@wordpress/i18n';
import { useI18n } from '@wordpress/react-i18n';
import React, { useEffect } from 'react';
import React, { useEffect, useState } from 'react';
import { ONBOARD_STORE } from 'calypso/landing/stepper/stores';
import { UrlData, GoToStep, RecordTracksEvent, ImporterPlatform } from '../types';
import { convertPlatformName, convertToFriendlyWebsiteName } from '../util';
Expand All @@ -13,8 +13,6 @@ import ImportPreview from './preview';
import type { OnboardSelect } from '@automattic/data-stores';
import './style.scss';

/* eslint-disable wpcalypso/jsx-classname-namespace */

const trackEventName = 'calypso_signup_step_start';
const trackEventParams = {
flow: 'importer',
Expand All @@ -34,7 +32,7 @@ const ReadyPreviewStep: React.FunctionComponent< ReadyPreviewProps > = ( {
recordTracksEvent,
} ) => {
const { __ } = useI18n();
const [ isModalDetailsOpen, setIsModalDetailsOpen ] = React.useState( false );
const [ isModalDetailsOpen, setIsModalDetailsOpen ] = useState( false );

const recordReadyScreenEvent = () => {
recordTracksEvent( trackEventName, {
Expand All @@ -56,8 +54,8 @@ const ReadyPreviewStep: React.FunctionComponent< ReadyPreviewProps > = ( {
} );
};

useEffect( recordReadyScreenEvent, [] );
useEffect( recordImportGuideEvent, [ isModalDetailsOpen ] );
useEffect( () => recordReadyScreenEvent(), [ urlData.platform ] );
useEffect( () => recordImportGuideEvent(), [ isModalDetailsOpen ] );

return (
<>
Expand Down