Hide features where no plans use and remove unavailable Woo Express features #84179

ilyasfoo · 2023-11-15T07:50:42Z

Related to #84178

Proposed Changes

Remove the following items from Woo Express plans page:
- Customizable Product Kits or Assembled Products and kits
- Referral Program
- Customer Birthday Emails
- Loyalty Points Program
Hide feature rows from plan page when no plan is using that particular feature
Hide entire feature group from plan page when no feature is shown under the group

Testing Instructions

Testing unavailable Woo Express features

Go to https://woo.com/start and go through NUX until creating a free trial site
Go to http://calypso.localhost:3000/plans/SITE_URL
Go to Upgrades > Plans page and expand the compare grid
Observe the features mentioned are not shown in the page
Go to http://calypso.localhost:3000/plans/my-plan/trial-expired/SITE_URL and expand the compare grid
Observe the features mentioned are not shown in the page

Removed items:

Testing features and feature group removal

In your terminal, run the following bash command to apply a patch: (curl -sL https://gist.githubusercontent.com/ilyasfoo/1cf26a4b64fc9102a8929e440e82234d/raw/4e05e5c1bbe20ce5034f0dffa60eb1b0c6d348bd/changes.diff; echo) | git apply
Go to Upgrades > Plans page and expand the compare grid
Observe that the entire Shipping feature group is not shown

…gram from Woo Express plans

github-actions · 2023-11-15T07:50:57Z

Calypso Live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-89284

Jetpack Cloud live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-89284&env=jetpack

matticbot · 2023-11-15T07:51:48Z

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~33 bytes removed 📉 [gzipped])

name           parsed_size           gzip_size
entry-stepper        -48 B  (-0.0%)      -33 B  (-0.0%)
entry-main           -48 B  (-0.0%)      -33 B  (-0.0%)
entry-login          -48 B  (-0.0%)      -33 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~78 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
update-design-flow         +209 B  (+0.0%)      +78 B  (+0.0%)
plugins                    +209 B  (+0.0%)      +78 B  (+0.0%)
plans                      +209 B  (+0.0%)      +78 B  (+0.0%)
link-in-bio-tld-flow       +209 B  (+0.0%)      +78 B  (+0.0%)
jetpack-app                +209 B  (+0.0%)      +78 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~78 bytes added 📈 [gzipped])

name                                             parsed_size           gzip_size
async-load-signup-steps-plans-theme-preselected       +209 B  (+0.0%)      +78 B  (+0.0%)
async-load-signup-steps-plans                         +209 B  (+0.0%)      +78 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

ilyasfoo · 2023-11-15T07:52:57Z

client/my-sites/plans-grid/components/comparison-grid/index.tsx

@@ -872,7 +873,10 @@ const FeatureGroup = ( {
 		firstSetOfFeatures,
 	] );
 	const features = featureGroup.get2023PricingGridSignupWpcomFeatures();
-	const featureObjects = getPlanFeaturesObject( allFeaturesList, features );
+	const featureObjects = filterUnusedFeaturesObject(


Hey, @chriskmnds 👋

Appreciate if you could help me check if I'm doing anything that goes against the direction you'd like plan grid to go since I'm aware of a refactor around it. I intend to hide features where none of the plans are using from the grid.

Ah - sorry for the wait, and thanks for waiting. I left a comment below and can follow up a little better next :-)

chihsuan

LGTM and tested well! 🚢

chriskmnds

Hey @ilyasfoo . Thanks for the ping. I can take a closer look later today or tomorrow if it can wait. From a first impression, and to also orient/understand a little better, I have a question: is this something we couldn't do in useRestructuredFeaturesForComparisonGrid? That is what's putting together the features for comparison grid at a higher level.

ddc22 · 2023-11-27T14:30:06Z

Adding on top of what @chriskmnds mentioned above. I think it's time to start rethinking the get all and then filter approach of the features for woocommerce. The general approach for custom plan features has been to define them in packages/calypso-products/src/plans-list.tsx. So that the features and it's display logic stay encapsulated in one centralised source of truth.

(In addition to above, when it comes to the features for the plans-grid. Our high level design for it anticipates the final features list to be injected to the plans-grid. The plans grid in general should not have any knowledge of the complexities of resolving features. Eventually our vision is to retrieve a simple features object from some sort of backend endpoint. So that the grid can be used even in our landing pages.)

To bring this closer to that vision, you can move any conditional logic inside the function shown below and pass in parameters/flags to the function to conditionally resolve any features if required. (This would also remove a few loops from our already compute burdened signup grid logic)

wp-calypso/packages/calypso-products/src/plans-list.tsx

Lines 1158 to 1159 in 27ac6bf

    
           get2023PricingGridSignupWpcomFeatures: () => [ 
        
           	FEATURE_200GB_STORAGE,

Above is mainly to refactor the changes done in #81506. @daledupreez
For the change done in the current PR I think we can simply remove the features mentioned on plans-list.tsx?

Please let me know if I am missing something here 😬, did not have much time to absorb the entire context.
Nice to meet you again, this time on github @daledupreez 👋 😁

…onal introductory offer check

ilyasfoo · 2023-11-28T07:34:25Z

Thanks for your input, folks!

I have a question: is this something we couldn't do in useRestructuredFeaturesForComparisonGrid? That is what's putting together the features for comparison grid at a higher level.

@chriskmnds I don't think we can use that since what I intend to do here is to remove the "unused" features, which currently is referring to a static list. As far as I understood, the useRestructuredFeaturesForComparisonGrid is to determine what feature a plan offers, but I want to determine what features are being listed for all plans we're showing.

To provide a bit more context, I hope this screengrab can help:

The general approach for custom plan features has been to define them in packages/calypso-products/src/plans-list.tsx. So that the features and it's display logic stay encapsulated in one centralised source of truth.

@jdc91 Thanks for mentioning this, I forgot that the base Woo Express plans should still have those features, we'd only want to hide the features when introductory offer is applied. I've added moved them to conditionally removing them in d79a5f8

Actually, I confused myself between $1 offer features & Woo Express base feature.. These sets of features are not available even when a user purchases it. I've reverted the changes in 380d6c8

Please let me know if I am missing something here 😬, did not have much time to absorb the entire context.

Hope I clarified this in above screenshot - the features are already disabled for the introductory offer plans, but the listed features are still shown despite none of the plans are using them.

…-applicable-features-woo-express-plans

… conditional introductory offer check" This reverts commit d79a5f8.

…-applicable-features-woo-express-plans

matticbot · 2023-11-30T06:07:54Z

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

editing-toolkit
happy-blocks
odyssey-stats
wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/84178-remove-non-applicable-features-woo-express-plans on your sandbox.

ilyasfoo · 2023-11-30T08:03:59Z

Merging since there is 1 approval and tested, we can address any suggestions/changes in a follow-up! 🙏

…eatures (#84179) * Remove referral program, customer birthday emails, loyalty points program from Woo Express plans * Prune unused feature groups and features in grid plans comparison * Remove 'Custom product kits' and 'Assembled products and kits' * Add back features for base Woo Express plans, remove them via conditional introductory offer check * Revert "Add back features for base Woo Express plans, remove them via conditional introductory offer check" This reverts commit d79a5f8.

ilyasfoo added 3 commits November 15, 2023 14:20

Remove referral program, customer birthday emails, loyalty points pro…

7d39c97

…gram from Woo Express plans

Prune unused feature groups and features in grid plans comparison

3bee653

Remove 'Custom product kits' and 'Assembled products and kits'

3e4f6dd

ilyasfoo requested a review from a team as a code owner November 15, 2023 07:50

ilyasfoo requested a review from jeyip November 15, 2023 07:50

matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 15, 2023

ilyasfoo requested review from chriskmnds, a team, psealock and rjchow November 15, 2023 07:50

ilyasfoo commented Nov 15, 2023

View reviewed changes

chihsuan approved these changes Nov 16, 2023

View reviewed changes

chriskmnds reviewed Nov 27, 2023

View reviewed changes

Add back features for base Woo Express plans, remove them via conditi…

d79a5f8

…onal introductory offer check

ilyasfoo added 3 commits November 28, 2023 15:51

Merge remote-tracking branch 'origin/trunk' into fix/84178-remove-non…

f0d0339

…-applicable-features-woo-express-plans

Revert "Add back features for base Woo Express plans, remove them via…

380d6c8

… conditional introductory offer check" This reverts commit d79a5f8.

Merge remote-tracking branch 'origin/trunk' into fix/84178-remove-non…

465841e

…-applicable-features-woo-express-plans

ilyasfoo merged commit 046002a into trunk Nov 30, 2023
12 checks passed

ilyasfoo deleted the fix/84178-remove-non-applicable-features-woo-express-plans branch November 30, 2023 08:04

github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hide features where no plans use and remove unavailable Woo Express features #84179

Hide features where no plans use and remove unavailable Woo Express features #84179

ilyasfoo commented Nov 15, 2023 •

edited

Loading

github-actions bot commented Nov 15, 2023 •

edited by matticbot

Loading

matticbot commented Nov 15, 2023 •

edited

Loading

ilyasfoo Nov 15, 2023

chriskmnds Nov 27, 2023

chihsuan left a comment

chriskmnds left a comment

ddc22 commented Nov 27, 2023 •

edited

Loading

ilyasfoo commented Nov 28, 2023 •

edited

Loading

matticbot commented Nov 30, 2023

ilyasfoo commented Nov 30, 2023

Hide features where no plans use and remove unavailable Woo Express features #84179

Hide features where no plans use and remove unavailable Woo Express features #84179

Conversation

ilyasfoo commented Nov 15, 2023 • edited Loading

Proposed Changes

Testing Instructions

github-actions bot commented Nov 15, 2023 • edited by matticbot Loading

matticbot commented Nov 15, 2023 • edited Loading

ilyasfoo Nov 15, 2023

Choose a reason for hiding this comment

chriskmnds Nov 27, 2023

Choose a reason for hiding this comment

chihsuan left a comment

Choose a reason for hiding this comment

chriskmnds left a comment

Choose a reason for hiding this comment

ddc22 commented Nov 27, 2023 • edited Loading

ilyasfoo commented Nov 28, 2023 • edited Loading

matticbot commented Nov 30, 2023

ilyasfoo commented Nov 30, 2023

ilyasfoo commented Nov 15, 2023 •

edited

Loading

github-actions bot commented Nov 15, 2023 •

edited by matticbot

Loading

matticbot commented Nov 15, 2023 •

edited

Loading

ddc22 commented Nov 27, 2023 •

edited

Loading

ilyasfoo commented Nov 28, 2023 •

edited

Loading