Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove free domain copy from mobile view in plans page for Woo Express $1 offer #83859

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

ilyasfoo
Copy link
Contributor

@ilyasfoo ilyasfoo commented Nov 3, 2023

Proposed Changes

Report: p1699002169274869-slack-C03Q87XT1QF

  • Remove free domain copy when viewing plans page for Woo Express plans with eligible $1 offer.

Testing Instructions

  • Use an existing Woo Express free trial site
  • Alternatively, go to https://woocommerce.com/start/#/ and go through the whole NUX flow and set up a free trial site
  • After the site is created, go to http://calypso.localhost:3000/plans/SITE_URL
  • Make sure to select the annual tab
  • Shrink your screen to mobile size ( < 1052px )
  • Observe in both essentials and performance plan do not have Free domain for one year displayed

Before:
image

After:
image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@ilyasfoo ilyasfoo requested a review from a team as a code owner November 3, 2023 11:12
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 3, 2023
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~28 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
update-design-flow          +90 B  (+0.0%)      +28 B  (+0.0%)
plugins                     +90 B  (+0.0%)      +28 B  (+0.0%)
plans                       +90 B  (+0.0%)      +28 B  (+0.0%)
link-in-bio-tld-flow        +90 B  (+0.0%)      +28 B  (+0.0%)
jetpack-app                 +90 B  (+0.0%)      +28 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~28 bytes added 📈 [gzipped])

name                                             parsed_size           gzip_size
async-load-signup-steps-plans-theme-preselected        +90 B  (+0.0%)      +28 B  (+0.0%)
async-load-signup-steps-plans                          +90 B  (+0.0%)      +28 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

// Remove the custom domain feature for Woo Express plans with introductory offer.
if (
isWooExpressPlan( planSlug ) &&
! gridPlan.features.wpcomFeatures.some(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're leveraging the introductory offer check from here

@ilyasfoo ilyasfoo requested review from a team, chihsuan and moon0326 November 3, 2023 11:16
Copy link
Contributor

@crunnells crunnells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested well. 🚢

@ilyasfoo ilyasfoo merged commit a9bc858 into trunk Nov 6, 2023
21 of 22 checks passed
@ilyasfoo ilyasfoo deleted the fix/free-domain-woo-express-onedollar-mobile branch November 6, 2023 12:43
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants