-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove free domain copy from mobile view in plans page for Woo Express $1 offer #83859
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~28 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~28 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
// Remove the custom domain feature for Woo Express plans with introductory offer. | ||
if ( | ||
isWooExpressPlan( planSlug ) && | ||
! gridPlan.features.wpcomFeatures.some( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're leveraging the introductory offer check from here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested well. 🚢
Proposed Changes
Report: p1699002169274869-slack-C03Q87XT1QF
Testing Instructions
Free domain for one year
displayedBefore:
After:
Pre-merge Checklist