Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme Discovery: Add the Assembler CTA and Randomize the Collections #83239

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Theme Discovery: Add the Assembler CTA and Randomize the Collections #83239

merged 2 commits into from
Oct 19, 2023

Conversation

Copons
Copy link
Contributor

@Copons Copons commented Oct 19, 2023

Related to https://github.com/Automattic/dotcom-forge/issues/3941

Proposed Changes

  • Extract the getSiteAssemblerUrl for convenience (cc @Automattic/lego).
  • Add the Assembler CTA after the third collection in the Theme Discovery context.
  • Randomize the collections.

Testing Instructions

  • Open the Calypso Live link in a logged-out tab.
  • Append /themes?flags=themes/discovery-lots.
  • Ensure the collections are in random order.
  • Ensure the Assembler CTA ("Design your own") appears after the third collection, and works as expected.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@Copons Copons added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Theme Showcase The theme showcase screen in Calypso in Appearance > Themes. labels Oct 19, 2023
@Copons Copons requested a review from a team October 19, 2023 13:02
@Copons Copons self-assigned this Oct 19, 2023
@Copons Copons marked this pull request as ready for review October 19, 2023 13:02
@github-actions
Copy link

github-actions bot commented Oct 19, 2023 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-84996
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-84996&env=jetpack

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~325 bytes added 📈 [gzipped])

name    parsed_size           gzip_size
themes       +945 B  (+0.1%)     +325 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~47 bytes added 📈 [gzipped])

name                                     parsed_size           gzip_size
async-load-signup-steps-theme-selection       +161 B  (+0.1%)      +10 B  (+0.0%)
async-load-design-blocks                      +161 B  (+0.0%)      +37 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

dsas
dsas reviewed Oct 19, 2023
View reviewed changes
client/my-sites/themes/collections/theme-collections-layout.tsx
function ThemeCollectionsLayout( props: ThemeCollectionsLayoutProps ) {
const { onSeeAll } = props;

const collections = Object.values( THEME_COLLECTIONS ).map( ( collection ) => {
const collections = Object.values( THEME_COLLECTIONS ).sort( () => Math.random() - 0.5 );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah cute, it took me a second to figure out what's going on.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Courtesy of ChatGPT courtesy of a random StackOverflow answer. 😄

@Copons Copons merged commit 690baa6 into trunk Oct 19, 2023
@Copons Copons deleted the update/theme-discovery-random-layout branch October 19, 2023 15:04
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsas dsas dsas approved these changes

Assignees

@Copons Copons

Labels
[Feature] Theme Showcase The theme showcase screen in Calypso in Appearance > Themes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Copons @matticbot @dsas